From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-out.m-online.net ([2001:a60:0:28:0:1:25:1])
 by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux))
 id 1W5dU2-0001Kq-FY
 for linux-mtd@lists.infradead.org; Tue, 21 Jan 2014 15:43:25 +0000
From: Marek Vasut <marex@denx.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Subject: Re: [PATCH 4/4] mtd: m25p80: Enable Dual SPI read transfers for
 s25fl256s1 and s25fl512s
Date: Tue, 21 Jan 2014 16:42:55 +0100
References: <1390309159-19643-1-git-send-email-geert@linux-m68k.org>
 <1390309159-19643-5-git-send-email-geert@linux-m68k.org>
In-Reply-To: <1390309159-19643-5-git-send-email-geert@linux-m68k.org>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201401211642.55461.marex@denx.de>
Cc: Geert Uytterhoeven <geert+renesas@linux-m68k.org>,
 linux-spi@vger.kernel.org, linux-mtd@lists.infradead.org,
 Sourav Poddar <sourav.poddar@ti.com>,
 Brian Norris <computersforpeace@gmail.com>,
 David Woodhouse <dwmw2@infradead.org>
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Tuesday, January 21, 2014 at 01:59:19 PM, Geert Uytterhoeven wrote:
> From: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> 
> Spansion s25fl256s1 and s25fl512s support Dual SPI transfers, hence set the
> M25P80_DUAL_READ flag.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@linux-m68k.org>
> ---
>  drivers/mtd/devices/m25p80.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/mtd/devices/m25p80.c b/drivers/mtd/devices/m25p80.c
> index 73bf661100f7..f0871a2e449d 100644
> --- a/drivers/mtd/devices/m25p80.c
> +++ b/drivers/mtd/devices/m25p80.c
> @@ -960,8 +960,8 @@ static const struct spi_device_id m25p_ids[] = {
>  	{ "s25sl032p",  INFO(0x010215, 0x4d00,  64 * 1024,  64, 0) },
>  	{ "s25sl064p",  INFO(0x010216, 0x4d00,  64 * 1024, 128, 0) },
>  	{ "s25fl256s0", INFO(0x010219, 0x4d00, 256 * 1024, 128, 0) },
> -	{ "s25fl256s1", INFO(0x010219, 0x4d01,  64 * 1024, 512, 
M25P80_QUAD_READ)
> }, -	{ "s25fl512s",  INFO(0x010220, 0x4d00, 256 * 1024, 256,
> M25P80_QUAD_READ) }, +	{ "s25fl256s1", INFO(0x010219, 0x4d01,  64 * 1024,
> 512, M25P80_DUAL_READ | M25P80_QUAD_READ) }, +	{ "s25fl512s", 
> INFO(0x010220, 0x4d00, 256 * 1024, 256, M25P80_DUAL_READ |
> M25P80_QUAD_READ) }, { "s70fl01gs",  INFO(0x010221, 0x4d00, 256 * 1024,
> 256, 0) },
>  	{ "s25sl12800", INFO(0x012018, 0x0300, 256 * 1024,  64, 0) },
>  	{ "s25sl12801", INFO(0x012018, 0x0301,  64 * 1024, 256, 0) },

Why don't you lump this together with 1/4 ? :)

Best regards,
Marek Vasut