* [PATCH 4/4] mtd: block2mtd: mutex_init moved
@ 2014-01-23 19:54 Fabian Frederick
2014-01-25 5:26 ` Ezequiel Garcia
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Frederick @ 2014-01-23 19:54 UTC (permalink / raw)
To: linux-mtd; +Cc: akpm, rdunlap, joern, linux-kernel, ezequiel.garcia
mutex_init declared when mtd structure is available
Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
drivers/mtd/devices/block2mtd.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
index f0fd4fc..5b9b145 100644
--- a/drivers/mtd/devices/block2mtd.c
+++ b/drivers/mtd/devices/block2mtd.c
@@ -254,16 +254,15 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
goto devinit_err1;
}
+ name = kasprintf(GFP_KERNEL, "block2mtd: %s", devname);
+ if (!name)
+ goto devinit_err1;
+
mutex_init(&dev->write_mutex);
/* Setup the MTD structure */
/* make the name contain the block device in */
- name = kasprintf(GFP_KERNEL, "block2mtd: %s", devname);
- if (!name)
- goto devinit_err2;
-
dev->mtd.name = name;
-
dev->mtd.size = dev->blkdev->bd_inode->i_size & PAGE_MASK;
dev->mtd.erasesize = erase_size;
dev->mtd.writesize = 1;
--
1.8.1.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 4/4] mtd: block2mtd: mutex_init moved
2014-01-23 19:54 [PATCH 4/4] mtd: block2mtd: mutex_init moved Fabian Frederick
@ 2014-01-25 5:26 ` Ezequiel Garcia
0 siblings, 0 replies; 2+ messages in thread
From: Ezequiel Garcia @ 2014-01-25 5:26 UTC (permalink / raw)
To: Fabian Frederick; +Cc: joern, akpm, rdunlap, linux-mtd, linux-kernel
On Thu, Jan 23, 2014 at 08:54:56PM +0100, Fabian Frederick wrote:
> mutex_init declared when mtd structure is available
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/mtd/devices/block2mtd.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
> index f0fd4fc..5b9b145 100644
> --- a/drivers/mtd/devices/block2mtd.c
> +++ b/drivers/mtd/devices/block2mtd.c
> @@ -254,16 +254,15 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
> goto devinit_err1;
> }
>
> + name = kasprintf(GFP_KERNEL, "block2mtd: %s", devname);
> + if (!name)
> + goto devinit_err1;
> +
> mutex_init(&dev->write_mutex);
>
> /* Setup the MTD structure */
> /* make the name contain the block device in */
> - name = kasprintf(GFP_KERNEL, "block2mtd: %s", devname);
> - if (!name)
> - goto devinit_err2;
> -
> dev->mtd.name = name;
> -
> dev->mtd.size = dev->blkdev->bd_inode->i_size & PAGE_MASK;
> dev->mtd.erasesize = erase_size;
> dev->mtd.writesize = 1;
> --
> 1.8.1.4
Hm.. this change doesn't seem to make sense. You just moved the name
format to happen before the mutex_init. I wonder if I'm missing something.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-01-25 5:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-01-23 19:54 [PATCH 4/4] mtd: block2mtd: mutex_init moved Fabian Frederick
2014-01-25 5:26 ` Ezequiel Garcia
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).