From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Fabian Frederick <fabf@skynet.be>
Cc: joern@lazybastard.org, akpm@linux-foundation.org,
rdunlap@infradead.org, linux-mtd@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] mtd: block2mtd: Add mutex_destroy
Date: Sat, 25 Jan 2014 02:38:17 -0300 [thread overview]
Message-ID: <20140125053816.GB24609@localhost> (raw)
In-Reply-To: <20140123205147.943d63fecf3140aa6cc76994@skynet.be>
On Thu, Jan 23, 2014 at 08:51:47PM +0100, Fabian Frederick wrote:
> mutex_destroy added on each device in block2mtd_exit and add_device failure
>
> Signed-off-by: Fabian Frederick <fabf@skynet.be>
> ---
> drivers/mtd/devices/block2mtd.c | 13 ++++++++-----
> 1 file changed, 8 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/mtd/devices/block2mtd.c b/drivers/mtd/devices/block2mtd.c
> index 0efee5b..8071596 100644
> --- a/drivers/mtd/devices/block2mtd.c
> +++ b/drivers/mtd/devices/block2mtd.c
> @@ -240,14 +240,14 @@ static struct block2mtd_dev *add_device(char *devname, int erase_size)
>
> if (IS_ERR(bdev)) {
> pr_err("error: cannot open device %s\n", devname);
> - goto devinit_err;
> + goto devinit_err1;
Ah, this one commit looks good, but the naming of the labels doesn't.
Instead, you should use a name describing what the error path does,
such as "err_free_block2mtd" and "err_destroy_mutex" or something like that.
We have a language full of words with meaning, so it's shame to use
dumb numbers :-)
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2014-01-25 5:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-23 19:51 [PATCH 2/4] mtd: block2mtd: Add mutex_destroy Fabian Frederick
2014-01-25 5:38 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140125053816.GB24609@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=akpm@linux-foundation.org \
--cc=fabf@skynet.be \
--cc=joern@lazybastard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).