From: Brian Norris <computersforpeace@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH fix] mtd: nand: kill the the NAND_MAX_PAGESIZE/NAND_MAX_OOBSIZE for nand_buffers{}
Date: Tue, 28 Jan 2014 16:23:07 -0800 [thread overview]
Message-ID: <20140129002307.GD8919@ld-irv-0074> (raw)
In-Reply-To: <1389594432-23482-1-git-send-email-b32955@freescale.com>
On Mon, Jan 13, 2014 at 02:27:12PM +0800, Huang Shijie wrote:
> The patch converts the arrays to buffer pointers for nand_buffers{}.
>
> The cafe_nand.c is the only NAND_OWN_BUFFERS user which allocates
> a nand_buffers{} itself.
>
> This patch disables the DMA for nand_scan_ident, and restore the DMA
> status after we finish the nand_scan_ident. By this way, we can get the
> mtd->writesize and mtd->oobsize, and then allocates the cafe->dmabuf
> with them.
>
> Since the cafe_nand.c uses the NAND_ECC_HW_SYNDROME ECC mode, we do not
> allocate the buffers for @ecccalc and @ecccode.
>
> Signed-off-by: Huang Shijie <b32955@freescale.com>
> ---
>
> fix: Setup the DMA address after we have allocated the DMA buffer.
Thanks, looks OK. Pushed to l2-mtd.git/next.
Brian
next prev parent reply other threads:[~2014-01-29 0:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-20 16:02 [PATCH 0/4] mtd: kill the NAND_MAX_PAGESIZE/NAND_MAX_OOBSIZE Huang Shijie
2013-12-20 16:02 ` [PATCH 1/4] mtd: mxc-nand: " Huang Shijie
2013-12-20 16:02 ` [PATCH 2/4] mtd: denali: " Huang Shijie
2013-12-20 16:02 ` [PATCH 3/4] mtd: nand: kill the the NAND_MAX_PAGESIZE/NAND_MAX_OOBSIZE for nand_buffers{} Huang Shijie
2014-01-11 23:39 ` Brian Norris
2014-01-11 23:43 ` Russell King - ARM Linux
2014-01-12 0:04 ` Brian Norris
2014-01-13 6:27 ` [PATCH fix] " Huang Shijie
2014-01-29 0:23 ` Brian Norris [this message]
2013-12-20 16:02 ` [PATCH 4/4] mtd: nand: remove the NAND_MAX_PAGESIZE/NAND_MAX_OOBSIZE Huang Shijie
2014-01-29 0:23 ` Brian Norris
2013-12-20 17:13 ` [PATCH 0/4] mtd: kill " Josh Triplett
2014-01-11 23:47 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140129002307.GD8919@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=b32955@freescale.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).