From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: linux-mtd@lists.infradead.org, Pekon Gupta <pekon@ti.com>,
u.kleine-koenig@pengutronix.de
Subject: Re: [PATCH 2/2] mtd: nand: don't use read_buf for 8-bit ONFI transfers
Date: Thu, 30 Jan 2014 09:20:25 -0300 [thread overview]
Message-ID: <20140130122024.GB11285@localhost> (raw)
In-Reply-To: <1391033909-6563-2-git-send-email-computersforpeace@gmail.com>
On Wed, Jan 29, 2014 at 02:18:29PM -0800, Brian Norris wrote:
> Use a repeated read_byte() instead of read_buf(), since for x16 buswidth
> devices, we need to avoid the upper I/O[16:9] bits. See the following
> commit for reference:
>
> commit 05f7835975dad6b3b517f9e23415985e648fb875
> Author: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> Date: Thu Dec 5 22:22:04 2013 +0100
>
> mtd: nand: don't use {read,write}_buf for 8-bit transfers
>
> Now, I think that all barriers to probing ONFI on x16 devices are
> removed, so remove the check from nand_flash_detect_onfi().
>
> Tested on 8-bit ONFI NAND (Micron MT29F32G08CBADAWP).
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
FWIW:
* 8-bit device, ONFI-probed
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xf1
nand: Micron MT29F1G08ABADAH4
nand: 128MiB, SLC, page size: 2048, OOB size: 64
* 16-bit device, ID-probed
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xcc
nand: Micron NAND 512MiB 3,3V 16-bit
nand: 512MiB, SLC, page size: 2048, OOB size: 64
* 16-bit (same) device, ONFI-probed
nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xcc
nand: Micron MT29F4G16ABADAH4
nand: 512MiB, SLC, page size: 2048, OOB size: 64
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-01-30 12:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-29 22:18 [PATCH 1/2] mtd: nand: force NAND_CMD_READID onto 8-bit bus Brian Norris
2014-01-29 22:18 ` [PATCH 2/2] mtd: nand: don't use read_buf for 8-bit ONFI transfers Brian Norris
2014-01-30 12:20 ` Ezequiel Garcia [this message]
2014-01-30 12:17 ` [PATCH 1/2] mtd: nand: force NAND_CMD_READID onto 8-bit bus Ezequiel Garcia
2014-01-30 18:00 ` Brian Norris
2014-01-30 19:17 ` Gupta, Pekon
2014-01-30 19:51 ` Ezequiel Garcia
2014-01-30 20:18 ` Gupta, Pekon
2014-01-30 20:47 ` Brian Norris
2014-01-31 6:55 ` Gupta, Pekon
2014-01-31 18:04 ` Brian Norris
2014-01-30 20:39 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140130122024.GB11285@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).