From: Jean Delvare <jdelvare@suse.de>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: David Woodhouse <dwmw2@infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org,
Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Subject: Re: [PATCH 1/2] mtd/ts5500: Add dependency
Date: Fri, 14 Feb 2014 11:44:53 +0100 [thread overview]
Message-ID: <20140214114453.4e8aa74c@endymion.delvare> (raw)
In-Reply-To: <1392373926.783869053@f323.i.mail.ru>
Hi Alexander,
On Fri, 14 Feb 2014 14:32:06 +0400, Alexander Shiyan wrote:
> Пятница, 14 февраля 2014, 11:28 +01:00 от Jean Delvare <jdelvare@suse.de>:
> > There is no point in displaying the TS5500-specific driver entries if
> > TS5500 board support itself isn't enabled.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: David Woodhouse <dwmw2@infradead.org>
> > Cc: Brian Norris <computersforpeace@gmail.com>
> > Cc: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> > ---
> > drivers/mtd/maps/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > --- linux-3.14-rc2.orig/drivers/mtd/maps/Kconfig 2014-02-14 11:21:15.116363700
> > +0100
> > +++ linux-3.14-rc2/drivers/mtd/maps/Kconfig 2014-02-14 11:23:53.286863374
> > +0100
> > @@ -124,7 +124,7 @@ config MTD_NETSC520
> >
> > config MTD_TS5500
> > tristate "JEDEC Flash device mapped on Technologic Systems TS-5500"
> > - depends on X86
> > + depends on TS5500 || (X86 && COMPILE_TEST)
>
> TS5500 && (X86 || COMPILE_TEST) ?
Hmm, no. The way I wrote it is correct I believe. TS5500 itself depends
on X86. The driver is only needed on TS5500, but can be test-built in
any X86 kernel if needed.
--
Jean Delvare
Suse L3 Support
next prev parent reply other threads:[~2014-02-14 10:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-14 10:28 [PATCH 1/2] mtd/ts5500: Add dependency Jean Delvare
2014-02-14 10:32 ` Alexander Shiyan
2014-02-14 10:44 ` Jean Delvare [this message]
2014-02-14 10:56 ` Alexander Shiyan
2014-02-23 2:01 ` Brian Norris
2014-02-23 9:27 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140214114453.4e8aa74c@endymion.delvare \
--to=jdelvare@suse.de \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=shc_work@mail.ru \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox