From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Boris BREZILLON <b.brezillon.dev@gmail.com>
Cc: Grant Likely <grant.likely@secretlab.ca>,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2 1/2] of_mtd: Add helpers to get ECC strength and ECC step size
Date: Tue, 18 Feb 2014 17:25:53 -0300 [thread overview]
Message-ID: <20140218202552.GB13799@localhost> (raw)
In-Reply-To: <5303BC07.2090300@gmail.com>
On Tue, Feb 18, 2014 at 09:01:11PM +0100, Boris BREZILLON wrote:
> Le 18/02/2014 19:51, Ezequiel Garcia a écrit :
> > This commit adds simple helpers to obtain the devicetree properties
> > that specify the ECC strength and ECC step size to use on a given
> > NAND controller.
>
> As already discussed with you, IMHO these 2 properties should both
> be available to be meaningful, hence, we should provide an helper
> function that gets both properties or return an error if one of them
> is missing.
>
I think this way is both cleaner and simpler. I don't see the advantage
of having a single function.
> Do you plan to provide a default value (within controller drivers) if one
> of these properties is missing ? In this case seperating the helper
> functions make sense.
>
Being a general framework, we can't know what drivers will want to do,
which is why I usually like helper function to say as simple as
policy-free as possible.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-18 20:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 18:51 [PATCH v2 0/2] mtd: Add NAND ECC devicetree binding Ezequiel Garcia
2014-02-18 18:51 ` [PATCH v2 1/2] of_mtd: Add helpers to get ECC strength and ECC step size Ezequiel Garcia
2014-02-18 20:01 ` Boris BREZILLON
2014-02-18 20:25 ` Ezequiel Garcia [this message]
2014-02-24 15:44 ` Boris BREZILLON
2014-02-24 15:45 ` Boris BREZILLON
2014-02-24 16:13 ` Boris BREZILLON
2014-02-24 19:08 ` Grant Likely
2014-02-24 20:33 ` Ezequiel Garcia
2014-02-18 18:51 ` [PATCH v2 2/2] mtd: nand: Add a devicetree binding for " Ezequiel Garcia
2014-02-18 20:02 ` Boris BREZILLON
2014-02-23 23:59 ` [PATCH v2 0/2] mtd: Add NAND ECC devicetree binding Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140218202552.GB13799@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=b.brezillon.dev@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox