From: Greg KH <gregkh@linuxfoundation.org>
To: Ivan Khoronzhuk <ivan.khoronzhuk@ti.com>
Cc: mark.rutland@arm.com, devicetree@vger.kernel.org,
grygorii.strashko@ti.com, linux@arm.linux.org.uk,
pawel.moll@arm.com, swarren@wwwdotorg.org,
ijc+devicetree@hellion.org.uk, nsekhar@ti.com,
galak@kernel.crashing.org, rob.herring@calxeda.com,
linux-kernel@vger.kernel.org,
"\[initial author\] Murali Karicheri" <m-karicheri2@ti.com>,
santosh.shilimkar@ti.com, rob@landley.net,
linux-mtd@lists.infradead.org, dwmw2@infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver
Date: Wed, 19 Feb 2014 06:34:03 -0800 [thread overview]
Message-ID: <20140219143403.GA31063@kroah.com> (raw)
In-Reply-To: <53048822.2080307@ti.com>
On Wed, Feb 19, 2014 at 12:32:02PM +0200, Ivan Khoronzhuk wrote:
> >> + aemif->clk = devm_clk_get(dev, NULL);
> >> + if (IS_ERR(aemif->clk)) {
> >> + dev_err(dev, "cannot get clock 'aemif'\n");
> >> + return PTR_ERR(aemif->clk);
> > No freeing memory?
>
> There is no need to free memory explicitly.
> devm_kzalloc is used instead of kzalloc.
Yes, but where does the device on the error path get removed?
next prev parent reply other threads:[~2014-02-19 14:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-05 19:46 [PATCH v4 0/2] Introduce AEMIF driver for Davinci/Keystone archs Ivan Khoronzhuk
2014-02-05 19:46 ` [PATCH v4 1/2] memory: ti-aemif: introduce AEMIF driver Ivan Khoronzhuk
2014-02-18 20:30 ` Greg KH
2014-02-19 10:32 ` Ivan Khoronzhuk
2014-02-19 14:34 ` Greg KH [this message]
2014-02-19 17:04 ` Ivan Khoronzhuk
2014-02-05 19:46 ` [PATCH v4 2/2] memory: ti-aemif: add bindings for " Ivan Khoronzhuk
2014-02-10 16:14 ` Santosh Shilimkar
2014-02-18 14:41 ` [PATCH v4 0/2] Introduce AEMIF driver for Davinci/Keystone archs Santosh Shilimkar
2014-02-18 20:27 ` Greg KH
2014-02-18 20:34 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140219143403.GA31063@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@kernel.crashing.org \
--cc=grygorii.strashko@ti.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ivan.khoronzhuk@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux@arm.linux.org.uk \
--cc=m-karicheri2@ti.com \
--cc=mark.rutland@arm.com \
--cc=nsekhar@ti.com \
--cc=pawel.moll@arm.com \
--cc=rob.herring@calxeda.com \
--cc=rob@landley.net \
--cc=santosh.shilimkar@ti.com \
--cc=swarren@wwwdotorg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).