From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Brian Norris <computersforpeace@gmail.com>,
Boris BREZILLON <b.brezillon.dev@gmail.com>
Subject: Re: [PATCH v2 1/2] of_mtd: Add helpers to get ECC strength and ECC step size
Date: Mon, 24 Feb 2014 17:33:26 -0300 [thread overview]
Message-ID: <20140224203325.GA28620@localhost> (raw)
In-Reply-To: <CACxGe6u7HJD7Cz+6DTUX3QuA=SokZNzZHW-mvsFhq5JCX6tFYQ@mail.gmail.com>
On Mon, Feb 24, 2014 at 07:08:15PM +0000, Grant Likely wrote:
> On Mon, Feb 24, 2014 at 4:13 PM, Boris BREZILLON
> <b.brezillon.dev@gmail.com> wrote:
> > On 18/02/2014 19:51, Ezequiel Garcia wrote:
> >>
> >> This commit adds simple helpers to obtain the devicetree properties
> >> that specify the ECC strength and ECC step size to use on a given
> >> NAND controller.
> >>
> >> Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
> >> ---
> >> diff --git a/include/linux/of_mtd.h b/include/linux/of_mtd.h
> >> index cb32d9c..c078f99 100644
> >> --- a/include/linux/of_mtd.h
> >> +++ b/include/linux/of_mtd.h
> >> @@ -13,6 +13,8 @@
> >> #include <linux/of.h>
> >> int of_get_nand_ecc_mode(struct device_node *np);
> >> +int of_get_nand_ecc_step_size(struct device_node *np)
> >> +int of_get_nand_ecc_strength(struct device_node *np)
> >
> >
> > You forgot the semicolon.
>
> Repeat after me: "I shall not post patches that I have not compiled"
>
Certainly: "I shall not post patches that I have not compiled".
Hope this helps me learn the lesson.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-24 20:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 18:51 [PATCH v2 0/2] mtd: Add NAND ECC devicetree binding Ezequiel Garcia
2014-02-18 18:51 ` [PATCH v2 1/2] of_mtd: Add helpers to get ECC strength and ECC step size Ezequiel Garcia
2014-02-18 20:01 ` Boris BREZILLON
2014-02-18 20:25 ` Ezequiel Garcia
2014-02-24 15:44 ` Boris BREZILLON
2014-02-24 15:45 ` Boris BREZILLON
2014-02-24 16:13 ` Boris BREZILLON
2014-02-24 19:08 ` Grant Likely
2014-02-24 20:33 ` Ezequiel Garcia [this message]
2014-02-18 18:51 ` [PATCH v2 2/2] mtd: nand: Add a devicetree binding for " Ezequiel Garcia
2014-02-18 20:02 ` Boris BREZILLON
2014-02-23 23:59 ` [PATCH v2 0/2] mtd: Add NAND ECC devicetree binding Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224203325.GA28620@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=b.brezillon.dev@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=grant.likely@secretlab.ca \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox