From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Mike Frysinger <vapier@gentoo.org>,
Richard Weinberger <richard.weinberger@gmail.com>,
Michael Opdenacker <michael.opdenacker@free-electrons.com>,
linux-mtd@lists.infradead.org,
Piergiorgio Beruto <piergiorgio.beruto@gmail.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>, Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH v7 1/3] ubi: Introduce read-only block devices on top of UBI volumes
Date: Wed, 5 Mar 2014 09:52:29 -0300 [thread overview]
Message-ID: <20140305125229.GA776@arch.cereza> (raw)
In-Reply-To: <1394017054.6302.46.camel@sauron.fi.intel.com>
On Mar 05, Artem Bityutskiy wrote:
> On Mon, 2014-02-24 at 09:39 -0300, Ezequiel Garcia wrote:
> > +/* Attach a block device to an UBI volume */
> > +#define UBI_IOCVOLATTBLK _IO(UBI_VOL_IOC_MAGIC, 7)
>
> Ezequiel,
>
> please, change this before it goes upstream and instead, make the ioctls
> accept a 'struct ubi_blkcreate_req' object pointer.
>
> /**
> * blah
> * @padding1: reserved for future, not used, has to be zeroed
> */
> struct ubi_blkcreate_req {
> __s8 padding1[128];
> } __packed;
>
> This will make sure we have a possibility to extend this ioctl in the
> future with something like volume creation flags etc. Otherwise, if we
> need to add a flag, we'll have to introduce a new ioctl.
>
Sure, that sounds great. And I'll change this ioctl names:
UBI_IOCBLKCR and UBI_IOCBLKRM ?
Unless you object.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-05 12:53 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 12:39 [PATCH v7 0/3] ubi: Add block interface Ezequiel Garcia
2014-02-24 12:39 ` [PATCH v7 1/3] ubi: Introduce read-only block devices on top of UBI volumes Ezequiel Garcia
2014-02-25 16:25 ` [PATCH v8] " Ezequiel Garcia
2014-02-28 14:29 ` [PATCH v7 1/3] " Artem Bityutskiy
2014-02-28 14:56 ` Ezequiel Garcia
2014-03-05 10:57 ` Artem Bityutskiy
2014-03-05 12:52 ` Ezequiel Garcia [this message]
2014-03-05 12:55 ` Artem Bityutskiy
2014-02-24 12:39 ` [PATCH v7 2/3] ubi-utils: Add ubiblock tool Ezequiel Garcia
2014-03-04 10:09 ` Artem Bityutskiy
2014-03-04 10:16 ` Ezequiel Garcia
2014-02-24 12:39 ` [PATCH v7 3/3] Add UBI block interface documentation Ezequiel Garcia
2014-03-04 10:05 ` Artem Bityutskiy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305125229.GA776@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=michael.opdenacker@free-electrons.com \
--cc=piergiorgio.beruto@gmail.com \
--cc=richard.weinberger@gmail.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=vapier@gentoo.org \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox