From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Artem Bityutskiy <dedekind1@gmail.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] UBI: block: Use ENOSYS as return value when CONFIG_UBIBLOCK=n
Date: Wed, 5 Mar 2014 10:30:02 -0300 [thread overview]
Message-ID: <20140305133002.GA1284@arch.cereza> (raw)
In-Reply-To: <1393938044.6302.2.camel@sauron.fi.intel.com>
On Mar 04, Artem Bityutskiy wrote:
> On Tue, 2014-03-04 at 09:14 -0300, Ezequiel Garcia wrote:
> > On Tue, Mar 04, 2014 at 01:49:51PM +0200, Artem Bityutskiy wrote:
> > > On Tue, 2014-03-04 at 07:57 -0300, Ezequiel Garcia wrote:
> > > > In order to have a way of distinguishing an invalid ioctl from a
> > > > not supported (but otherwise valid) ioctl, this commit changes the
> > > > return value of the ioctl stubs from ENOTTY to ENOSYS.
> > >
> > > Sounds logical, no objections, except it is curious if this is something
> > > you invented or this is a general rule in the Linux kernel? If it is,
> > > may be you can point to some discussions, or give some example or other
> > > source of this knowledge? I just want to be educated a bit. Thanks!
> > >
> >
> > Yes, I think it's a pretty extended kernel practice to return -ENOSYS when
> > a function is not built or either not implemented.
>
> Pushed this one and the previous 3 ones. I think what is left is ioctl
> names and the user-space tool.
>
I'm seeing all the other patches pushed, but not this one. Do you want me to
send a rebased patch?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2014-03-05 13:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 10:57 [PATCH] UBI: block: Use ENOSYS as return value when CONFIG_UBIBLOCK=n Ezequiel Garcia
2014-03-04 11:49 ` Artem Bityutskiy
2014-03-04 12:14 ` Ezequiel Garcia
2014-03-04 13:00 ` Artem Bityutskiy
2014-03-05 13:30 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305133002.GA1284@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox