From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from imap.thunk.org ([2600:3c02::f03c:91ff:fe96:be03]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1WOEqr-0002wD-TU for linux-mtd@lists.infradead.org; Thu, 13 Mar 2014 23:15:50 +0000 Date: Thu, 13 Mar 2014 19:15:06 -0400 From: Theodore Ts'o To: Steven Whitehouse Subject: Re: [Cluster-devel] [PATCH] fs: push sync_filesystem() down to the file system's remount_fs() Message-ID: <20140313231506.GB16785@thunk.org> References: <20140313073936.GA14663@infradead.org> <1394720456-16629-1-git-send-email-tytso@mit.edu> <20140313162319.GA504@quack.suse.cz> <1394728103.2767.32.camel@menhir> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1394728103.2767.32.camel@menhir> Cc: jfs-discussion@lists.sourceforge.net, Jan Kara , Anders Larsen , linux-mtd@lists.infradead.org, Mikulas Patocka , Petr Vandrovec , codalist@TELEMANN.coda.cs.cmu.edu, linux-cifs@vger.kernel.org, linux-fsdevel@thunk.org, cluster-devel@redhat.com, Ext4 Developers List , Evgeniy Dushistov , Kees Cook , fuse-devel@lists.sourceforge.net, reiserfs-devel@vger.kernel.org, xfs@oss.sgi.com, linux-nilfs@vger.kernel.org, OGAWA Hirofumi , linux-nfs@vger.kernel.org, Artem Bityutskiy , linux-ntfs-dev@lists.sourceforge.net, samba-technical@lists.samba.org, Adrian Hunter , linux-f2fs-devel@lists.sourceforge.net, linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, Phillip Lougher , ocfs2-devel@oss.oracle.com List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Mar 13, 2014 at 04:28:23PM +0000, Steven Whitehouse wrote: > > I guess the same is true for other file systems which are mounted ro > too. So maybe a check for MS_RDONLY before doing the sync in those > cases? My original patch moved the sync_filesystem into the check for MS_RDONLY in the core VFS code. The objection was raised that there might be some file system out there that might depend on this behaviour. I can't imagine why, but I suppose it's at least theoretically possible. So the idea is that this particular patch is *guaranteed* not to make any difference. That way there can be no question about the patch'es correctness. I'm going to follow up with a patch for ext4 that does exactly that, but the idea is to allow each file system maintainer to do that for their own file system. I could do that as well for file systems that are "obviously" read-only, but then I'll find out that there's some wierd case where the file system can be used in a read-write fashion. (Example: UDF is normally used for DVD's, but at least in theory it can be used read/write --- I'm told that Windows supports read-write UDF file systems on USB sticks, and at least in theory it could be used as a inter-OS exchange format in situations where VFAT and exFAT might not be appropriate for various reasons.) Cheers, - Ted