From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>
Cc: Lior Amsalem <alior@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Seif Mazareeb <seif@marvell.com>,
Simon Guinot <sguinot@lacie.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Willy Tarreau <w@1wt.eu>
Subject: Re: [PATCH 1/4] mtd: nand: pxa3xx: Normalize ECC strength for ECC scheme selection
Date: Thu, 20 Mar 2014 14:39:22 -0300 [thread overview]
Message-ID: <20140320173922.GA1142@arch.cereza> (raw)
In-Reply-To: <1395071227-31909-2-git-send-email-ezequiel.garcia@free-electrons.com>
On Mar 17, Ezequiel Garcia wrote:
> @@ -1525,8 +1524,8 @@ KEEP_CONFIG:
> ecc_step = 512;
> }
>
> - ret = pxa_ecc_init(info, &chip->ecc, ecc_strength,
> - ecc_step, mtd->writesize);
> + ret = pxa_ecc_init(info, &chip->ecc, (ecc_strength * ecc_step) / 512,
> + mtd->writesize);
After a test report from Simon Guinot we found this normalization is horribly
wrong. It should be: (ecc_strength * 512) / ecc_step. I'll prepare a v2 and
make sure to test it properly this time!
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-20 17:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-17 15:47 [PATCH 0/4] pxa3xx-nand: Allow to specify an ECC scheme through DT Ezequiel Garcia
2014-03-17 15:47 ` [PATCH 1/4] mtd: nand: pxa3xx: Normalize ECC strength for ECC scheme selection Ezequiel Garcia
2014-03-20 17:39 ` Ezequiel Garcia [this message]
2014-03-17 15:47 ` [PATCH 2/4] mtd: nand: pxa3xx: Clean pxa_ecc_init() error handling Ezequiel Garcia
2014-03-17 15:47 ` [PATCH 3/4] mtd: nand: pxa3xx: Use ECC strength and step size devicetree binding Ezequiel Garcia
2014-03-17 15:47 ` [PATCH 4/4] mtd: nand: pxa3xx: Add supported ECC strength and step size to the DT binding Ezequiel Garcia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140320173922.GA1142@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=computersforpeace@gmail.com \
--cc=gregory.clement@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
--cc=seif@marvell.com \
--cc=sguinot@lacie.com \
--cc=tawfik@marvell.com \
--cc=thomas.petazzoni@free-electrons.com \
--cc=w@1wt.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox