Linux-mtd Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Cc: "David Mosberger-Tang" <davidm@egauge.net>,
	"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
	"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH] mtd: nand: fix byte addressing on 16-bit wide devices
Date: Fri, 21 Mar 2014 18:59:31 -0700	[thread overview]
Message-ID: <20140322015931.GB29542@ld-irv-0074> (raw)
In-Reply-To: <20140321185446.GA18141@arch.cereza>

On Fri, Mar 21, 2014 at 03:54:46PM -0300, Ezequiel Garcia wrote:
> (Ccing Brian and Uwe)

Thanks for the heads up. Probably would have read it anyway, but you
never know :)

> Brian: Related to this, the current code for fixing READID on 16-bit devices
> seem to apply *only* for drivers that don't override cmdfunc(), right?
> So each of the drivers that have their cmdfunc() currently need some
> tweak to support 16-bit devices.

I think I fixed up all current in-tree drivers that override cmdfunc()
(and David's newer patch fixes the remaining opcodes). Whether they need
a tweak or not depends on how their hardware handles addressing for x16.
For some, they need to selectively convert some byte addresses to word
addresses. But for others, the hardware might take care of the
addressing.

Brian

      parent reply	other threads:[~2014-03-22  2:07 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-21 17:42 [PATCH] mtd: nand: fix byte addressing on 16-bit wide devices David Mosberger
2014-03-21 18:05 ` Ezequiel Garcia
     [not found]   ` <CACwUX0PQP21PuSbQn6AvisaZuug9=JTwM3QoG5mXy54r6-tXCg@mail.gmail.com>
2014-03-21 18:19     ` Fwd: " David Mosberger-Tang
2014-03-21 18:54     ` Ezequiel Garcia
2014-03-21 19:43       ` David Mosberger
2014-03-22  2:01         ` Brian Norris
2014-03-22  1:59       ` Brian Norris [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140322015931.GB29542@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=davidm@egauge.net \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=u.kleine-koenig@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox