Re: [RFC 23/47] mtd: nand: stm_nand_bch: read and write page (BCH)

Lee Jones
2014-04-30T11:20:02Z

> >From: Lee Jones [mailto:lee.jones@linaro.org]
> >
> >Use DMA to read and/or write a single page of data.
> >
> >Signed-off-by: Lee Jones <lee.jones@linaro.org>
> >---
> > drivers/mtd/nand/stm_nand_bch.c | 119 ++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 119 insertions(+)
> >
> >diff --git a/drivers/mtd/nand/stm_nand_bch.c b/drivers/mtd/nand/stm_nand_bch.c
> >index 7874d85..6323590 100644
> >--- a/drivers/mtd/nand/stm_nand_bch.c
> >+++ b/drivers/mtd/nand/stm_nand_bch.c
> >@@ -21,6 +21,7 @@

[...]

> >+/* Returns the number of ECC errors, or '-1' for uncorrectable error */
> >+static int bch_read_page(struct nandi_controller *nandi,
> >+ loff_t offs,
> >+ uint8_t *buf)
> >+{

[...]

> >+ /* Use the maximum per-sector ECC count! */
>
> Firstly, this ecc checking and correction should not be part of bch_read_page().
> This should be part of chip->ecc.correct().

I'm not sure that's true. The functionality below isn't correcting
any data. I believe it's preventing a false-positive error return.
All calculate() and correct() behaviour is dealt with internally by
h/w. There should be no intervention from s/w, hence the lack of
call-back functions of the same name.

> But, I don't see your driver using nand_chip->ecc interfaces.
> Why do you want to break away from generic driver flow ? any controller limitation ?

When this driver was written, a great deal of the framework was not
present. I believe the author also wanted to prevent any changes in
the framework from adversely affecting the leaf driver. It was
considered that if there is no intention to upstream, it would be much
better to hack around the framework and have full control of the
driver.

Things are different now, as upstreaming is considered necessary.
It's my job to make this driver acceptable so it can be Mainlined.
This includes a 'port' to ensure the driver is using the correct
interfaces provided by the framework.

> I think much of the code in below patch can be reused from nand_base.c
> [RFC 43/47] mtd: nand: stm_nand_bch: read and write functions (BCH)

I agree and have taken care of this now.

> >+ ecc_err = readl(nandi->base + NANDBCH_ECC_SCORE_REG_A) & 0xff;
> >+ if (ecc_err == 0xff) {
> >+ /*
> >+ * Downgrade uncorrectable ECC error for an erased page,
> >+ * tolerating 'sectors_per_page' bits at zero.
> >+ */
> >+ ret = check_erased_page(buf, page_size,
> >+ nandi->sectors_per_page);
>
> This is also not correct. Here 'max_zeros' should be ecc.strength

I need to check this with the original author, but I'm inclined to
agree with you. I'll make the changes before re-submitting.

> >+ if (ret >= 0)
> >+ dev_dbg(nandi->dev,
> >+ "%s: erased page detected: \n"
> >+ " downgrading uncorrectable ECC error.\n",
> >+ __func__);
> >+ } else {
> >+ ret = (int)ecc_err;
> >+ }
> >+
> >+ return ret;
> >+}
> >+
>
> with regards, pekon

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog