Re: [RFC 01/47] mtd: nand: export useful functions from core driver

Ezequiel Garcia
2014-03-25T12:57:55Z

On Mar 25, Lee Jones wrote:
> These functions are utilised by the STM BCH NAND Controller driver.
>
[..]
> -static int nand_suspend(struct mtd_info *mtd)
> +int nand_suspend(struct mtd_info *mtd)
> {
> return nand_get_device(mtd, FL_PM_SUSPENDED);
> }
> +EXPORT_SYMBOL(nand_suspend);
>
> /**
> * nand_resume - [MTD Interface] Resume the NAND flash
> * @mtd: MTD device structure
> */
> -static void nand_resume(struct mtd_info *mtd)
> +void nand_resume(struct mtd_info *mtd)
> {
> struct nand_chip *chip = mtd->priv;
>
> @@ -2776,6 +2779,7 @@ static void nand_resume(struct mtd_info *mtd)
> pr_err("%s called for a chip which is not in suspended state\n",
> __func__);
> }
> +EXPORT_SYMBOL(nand_resume);
>

The patch that adds the PM support for the driver makes no use of these.

Can you detail why do you need to export these?
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering