Re: [RFC 35/47] mtd: nand: stm_nand_bch: dump bad blocks

Ezequiel Garcia
2014-03-25T12:53:29Z

On Mar 25, Lee Jones wrote:
> Inform the user of any known bad blocks during initialisation.
> Conversely, if there aren't any known bad blocks, let the user know
> the good news.
>
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
> drivers/mtd/nand/stm_nand_bch.c | 24 ++++++++++++++++++++++++
> 1 file changed, 24 insertions(+)
>
> diff --git a/drivers/mtd/nand/stm_nand_bch.c b/drivers/mtd/nand/stm_nand_bch.c
> index 6698b1f..abbb4d9 100644
> --- a/drivers/mtd/nand/stm_nand_bch.c
> +++ b/drivers/mtd/nand/stm_nand_bch.c
> @@ -1060,6 +1060,28 @@ static int bch_load_bbt(struct nandi_controller *nandi,
> return 0;
> }
>
> +static void nandi_dump_bad_blocks(struct nandi_controller *nandi)
> +{
> + int bad_count = 0;
> + uint32_t block;
> + uint8_t *bbt = nandi->info.bbt_info.bbt;
> + uint8_t mark;
> +
> + pr_info("BBT:\n");
> + for (block = 0; block < nandi->blocks_per_device; block++) {
> + mark = bbt_get_block_mark(bbt, block);
> + if (mark != BBT_MARK_GOOD) {
> + pr_info("\t\tBlock 0x%08x [%05u] marked bad [%s]\n",
> + block << nandi->block_shift, block,
> + (mark == BBT_MARK_BAD_FACTORY) ?
> + "Factory" : "Wear");
> + bad_count++;
> + }
> + }
> + if (bad_count == 0)
> + pr_info("\t\tNo bad blocks listed in BBT\n");
> +}
> +
> /*
> * Initialisation
> */
> @@ -1849,6 +1871,8 @@ static int stm_nand_bch_probe(struct platform_device *pdev)
> return err;
> }
>
> + nandi_dump_bad_blocks(nandi);
> +

Hm... this looks suspicious. Are you sure you need this?

The NAND BBT code prints the bad blocks at initialization-time. If that's
not the case for you, perhaps we should be fixing that in the BBT code,
rather than at a driver's level.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering