Re: [PATCH v4 4/5] mtd: nand: Allocate extra buffers needed for on-die ECC controller.

[Brian Norris <computersforpeace@gmail.com>]

Hi Pekon,

On Tue, Apr 01, 2014 at 07:37:46AM +0000, Pekon Gupta wrote:
> >From: Brian Norris [mailto:computersforpeace@gmail.com]
> >>On Mon, Mar 31, 2014 at 05:28:56PM -0600, David Mosberger wrote:
> [...]
> >> diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> >> index dbb99b3..456809b 100644
> >> --- a/include/linux/mtd/nand.h
> >> +++ b/include/linux/mtd/nand.h
> >> @@ -533,6 +533,8 @@ struct nand_buffers {
> >>  	uint8_t	*ecccalc;
> >>  	uint8_t	*ecccode;
> >>  	uint8_t *databuf;
> >> +	uint8_t *chkbuf;
> >> +	uint8_t *rawbuf;
> >
> >Do you really need two additional buffers? Can you get by with just one
> >of them?
> >
> 
> Some similar comments have been provided in the previous versions
> of the patch. But due to in-consistency in $subject, they might not
> be visible as a thread of same discussion.

Yeah, I didn't review every iteration so far. I'm possibly repeating
some things. I'll see where to respond on the old threads.

But here's a note to David: it looks like you sent 4 revisions in one
week. That's a bit fast. Perhaps you can wait a few more days on
spinning patch sets, especially when review is straddling a weekend like
that.

> You may like to review and comment on below threads also.
> 
> [PATCH] mtd: nand: Add support for Micron on-die ECC controller (rev2).
> http://lists.infradead.org/pipermail/linux-mtd/2014-March/052949.html
> 
> [RFC] mtd: nand: Preparatory patch for adding on-die ECC controller support ...
> http://lists.infradead.org/pipermail/linux-mtd/2014-March/052969.html

Brian