From: Brian Norris <computersforpeace@gmail.com>
To: Huang Shijie <b32955@freescale.com>
Cc: angus.clark@st.com, Russel King <linux@arm.linux.org.uk>,
broonie@linaro.org, dwmw2@infradead.org,
linux-doc@vger.kernel.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-mtd@lists.infradead.org,
pekon@ti.com, sourav.poddar@ti.com, shawn.guo@linaro.org,
lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v5 5/8 fix] mtd: m25p80: use the SPI nor framework
Date: Thu, 10 Apr 2014 12:29:02 -0700 [thread overview]
Message-ID: <20140410192902.GM32070@ld-irv-0074> (raw)
In-Reply-To: <20140410072509.GA24100@localhost>
On Thu, Apr 10, 2014 at 03:25:11PM +0800, Huang Shijie wrote:
> On Wed, Apr 09, 2014 at 02:37:49PM -0700, Brian Norris wrote:
> > > config MTD_M25P80
> > > tristate "Support most SPI Flash chips (AT26DF, M25P, W25X, ...)"
> > > - depends on SPI_MASTER
> > > + depends on SPI_MASTER && MTD_SPI_NOR_BASE
> > > help
> > > This enables access to most modern SPI flash chips, used for
> > > program and data storage. Series supported include Atmel AT26DF,
> >
> > Now that M25P80 depends on MTD_SPI_NOR_BASE (which I proposed to rename
> > to MTD_SPI_NOR a few hours ago), shouldn't we be updating everybody's
> > defconfigs? As it stands, the defconfigs that use M25P80 will just drop
> > it silently when built.
> >
> > And if so, I'm not sure how this should be handled. Should defconfig
> > patches be sent to their respective arch maintainers?
>
> IMHO, we should create a patch or several patches to add the MTD_SPI_NOR
> to the defconfigs.
Yeah, I think that's best.
> Another method is to select the MTD_SPI_NOR which we enable the MTD.
I'm pretty sure it's a rule that drivers should not 'select' subsystems.
> > Also, I think m25p80.c is no longer a "self-contained MTD device driver"
> > and should be moved under drivers/mtd/spi-nor/.
> If we move the m25p80.c to the drivers/mtd/spi-nor/, we also need to move
> other drivers too.
Which ones? I think it only makes sense to move those that depend on the
same core code (i.e., spi-nor.c), or have a close relation to it (so
Lee's st_spi_fsm.c is a candidate).
Brian
next prev parent reply other threads:[~2014-04-10 19:29 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 10:37 [PATCH v5 0/8] mtd: spi-nor: add a new framework for SPI NOR Huang Shijie
2014-02-24 10:37 ` [PATCH v5 1/8] mtd: spi-nor: copy the SPI NOR commands to a new header file Huang Shijie
2014-03-04 22:13 ` Marek Vasut
2014-03-05 2:59 ` Huang Shijie
2014-03-05 3:43 ` Marek Vasut
2014-03-05 5:45 ` Huang Shijie
2014-03-05 7:24 ` Gupta, Pekon
2014-03-05 13:36 ` Marek Vasut
2014-04-09 17:40 ` Brian Norris
2014-02-24 10:37 ` [PATCH v5 2/8] mtd: spi-nor: add the basic data structures Huang Shijie
2014-02-24 10:37 ` [PATCH v5 3/8] mtd: spi-nor: add the framework for SPI NOR Huang Shijie
2014-04-09 17:48 ` Brian Norris
2014-04-10 7:27 ` Huang Shijie
2014-02-24 10:37 ` [PATCH v5 4/8] Documentation: add the document for the SPI NOR framework Huang Shijie
2014-02-24 15:17 ` Konstantin Tokarev
2014-02-25 2:23 ` Huang Shijie
2014-02-28 7:58 ` [PATCH v5 4/8 fix] " Huang Shijie
2014-02-24 10:37 ` [PATCH v5 5/8] mtd: m25p80: use the SPI nor framework Huang Shijie
2014-02-28 7:55 ` [PATCH v5 5/8 fix] " Huang Shijie
2014-04-09 21:37 ` Brian Norris
2014-04-10 7:25 ` Huang Shijie
2014-04-10 19:29 ` Brian Norris [this message]
2014-04-11 0:32 ` Huang Shijie
2014-04-11 7:04 ` Lee Jones
2014-02-24 10:37 ` [PATCH v5 6/8] mtd: spi-nor: add a helper to find the spi_device_id Huang Shijie
2014-02-24 10:37 ` [PATCH v5 7/8] Documentation: add the binding file for Freescale QuadSPI driver Huang Shijie
2014-02-24 10:37 ` [PATCH v5 8/8] mtd: spi-nor: Add " Huang Shijie
2014-03-04 22:17 ` [PATCH v5 0/8] mtd: spi-nor: add a new framework for SPI NOR Marek Vasut
2014-03-12 8:13 ` Huang Shijie
2014-03-13 6:39 ` Brian Norris
2014-04-09 3:36 ` Brian Norris
2014-04-09 4:29 ` Huang Shijie
2014-04-09 17:47 ` Marek Vasut
2014-04-10 7:42 ` Lee Jones
2014-04-10 19:31 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140410192902.GM32070@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=angus.clark@st.com \
--cc=b32955@freescale.com \
--cc=broonie@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=pekon@ti.com \
--cc=shawn.guo@linaro.org \
--cc=sourav.poddar@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox