public inbox for linux-mtd@lists.infradead.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: Marek Vasut <marex@denx.de>, Huang Shijie <b32955@freescale.com>,
	Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH v2 08/10] mtd: st_spi_fsm: replace FLACH_CMD_* with SPINOR_OP_*
Date: Thu, 10 Apr 2014 17:24:25 -0700	[thread overview]
Message-ID: <20140411002425.GQ32070@ld-irv-0074> (raw)
In-Reply-To: <1397157664-24405-9-git-send-email-computersforpeace@gmail.com>

On Thu, Apr 10, 2014 at 12:21:02PM -0700, Brian Norris wrote:
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 2977f026f39d..b41bbbc531ff 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -294,12 +294,12 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q)
>  	lut_base = SEQID_QUAD_READ * 4;
>  
>  	if (q->nor_size <= SZ_16M) {
> -		cmd = SPINOR_OP_QUAD_READ;
> +		cmd = SPINOR_OP_READ_1_1_4;
>  		addrlen = ADDR24BIT;
>  		dummy = 8;
>  	} else {
>  		/* use the 4-byte address */
> -		cmd = SPINOR_OP_QUAD_READ;
> +		cmd = SPINOR_OP_READ_1_1_4;
>  		addrlen = ADDR32BIT;
>  		dummy = 8;
>  	}
> @@ -388,7 +388,7 @@ static void fsl_qspi_init_lut(struct fsl_qspi *q)
>  static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
>  {
>  	switch (cmd) {
> -	case SPINOR_OP_QUAD_READ:
> +	case SPINOR_OP_READ_1_1_4:
>  		return SEQID_QUAD_READ;
>  	case SPINOR_OP_WREN:
>  		return SEQID_WREN;

I'm sorry, I squashed these into the wrong patch. The full result
builds, but this is not bisect clean :(

I'll send out another version once I've had a better look at everything.
Sorry for the noise.

Brian

  reply	other threads:[~2014-04-11  0:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-04-10 19:20 [PATCH v2 00/10] mtd: spi-nor: misc. updates, de-duplication Brian Norris
2014-04-10 19:20 ` [PATCH v2 01/10] mtd: spi-nor: drop \t after #define Brian Norris
2014-04-10 19:20 ` [PATCH v2 02/10] mtd: spi-nor: re-name OPCODE_* to SPINOR_OP_* Brian Norris
2014-04-10 19:20 ` [PATCH v2 03/10] mtd: spi-nor: unify read opcode variants with ST SPI FSM Brian Norris
2014-04-11  0:23   ` Huang Shijie
2014-04-11  4:26     ` Brian Norris
2014-04-10 19:20 ` [PATCH v2 04/10] Documentation: spi-nor: rewrite some portions Brian Norris
2014-04-10 19:20 ` [PATCH v2 05/10] mtd: spi-nor: shorten Kconfig naming Brian Norris
2014-04-10 19:21 ` [PATCH v2 06/10] mtd: st_spi_fsm: fixup Kconfig dependency Brian Norris
2014-04-10 19:21 ` [PATCH v2 07/10] mtd: st_spi_fsm: kill duplicate CMD definitions Brian Norris
2014-04-10 19:21 ` [PATCH v2 08/10] mtd: st_spi_fsm: replace FLACH_CMD_* with SPINOR_OP_* Brian Norris
2014-04-11  0:24   ` Brian Norris [this message]
2014-04-10 19:21 ` [PATCH v2 09/10] mtd: st_spi_fsm: begin using spi-nor.h opcodes Brian Norris
2014-04-10 19:21 ` [PATCH v2 10/10] mtd: spi-nor: allow to be built as module Brian Norris
2014-04-10 19:22 ` [PATCH v2 00/10] mtd: spi-nor: misc. updates, de-duplication Brian Norris
2014-04-11  7:35 ` Marek Vasut

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140411002425.GQ32070@ld-irv-0074 \
    --to=computersforpeace@gmail.com \
    --cc=b32955@freescale.com \
    --cc=lee.jones@linaro.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marex@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox