From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Fri, 11 Apr 2014 08:32:05 +0800 From: Huang Shijie To: Brian Norris Subject: Re: [PATCH v5 5/8 fix] mtd: m25p80: use the SPI nor framework Message-ID: <20140411003203.GC3837@localhost.localdomain> References: <1393238262-8622-6-git-send-email-b32955@freescale.com> <1393574142-17234-1-git-send-email-b32955@freescale.com> <20140409213749.GH32070@ld-irv-0074> <20140410072509.GA24100@localhost> <20140410192902.GM32070@ld-irv-0074> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20140410192902.GM32070@ld-irv-0074> Cc: angus.clark@st.com, Russel King , broonie@linaro.org, lee.jones@linaro.org, linux-doc@vger.kernel.org, linux-spi@vger.kernel.org, Huang Shijie , devicetree@vger.kernel.org, linux-mtd@lists.infradead.org, pekon@ti.com, sourav.poddar@ti.com, shawn.guo@linaro.org, dwmw2@infradead.org, linux-arm-kernel@lists.infradead.org List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, Apr 10, 2014 at 12:29:02PM -0700, Brian Norris wrote: > > IMHO, we should create a patch or several patches to add the MTD_SPI_NOR > > to the defconfigs. > > Yeah, I think that's best. I will create a patch when i back to office. Or you can create it yourself. > > > > Also, I think m25p80.c is no longer a "self-contained MTD device driver" > > > and should be moved under drivers/mtd/spi-nor/. > > If we move the m25p80.c to the drivers/mtd/spi-nor/, we also need to move > > other drivers too. > > Which ones? I think it only makes sense to move those that depend on the > same core code (i.e., spi-nor.c), or have a close relation to it (so > Lee's st_spi_fsm.c is a candidate). yes, i mean the st_spi_fsm.c and other drivers which will use the spi-nor core code in the future. thanks Huang Shijie