From: Huang Shijie <b32955@freescale.com>
To: Marek Vasut <marex@denx.de>
Cc: linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
dwmw2@infradead.org
Subject: Re: [PATCH] mtd: spi-nor: fix the wrong dummy value
Date: Thu, 17 Apr 2014 13:01:25 +0800 [thread overview]
Message-ID: <20140417050123.GC29495@localhost> (raw)
In-Reply-To: <201404170140.29747.marex@denx.de>
On Thu, Apr 17, 2014 at 01:40:29AM +0200, Marek Vasut wrote:
> On Wednesday, April 16, 2014 at 10:18:19 AM, Huang Shijie wrote:
> > The dummy cycles is actually 8 for SPI fast/dual/quad read.
> >
> > This patch fixes the wrong dummy value for both the spi-nor.c and m25p80.c.
> >
> > Signed-off-by: Huang Shijie <b32955@freescale.com>
>
> Inspecting this patch, I see the code will behave identically with/without this
> patch. It is thus unclear to me from the commit message, why this change is
> necessary.
>
firstly, in theory, the dummy cycles should be 8, not 1.
secondly, the DDR QUAD READ may use 4 dummy cycles.
thanks
Huang Shijie
next prev parent reply other threads:[~2014-04-17 5:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-16 8:18 [PATCH] mtd: spi-nor: fix the wrong dummy value Huang Shijie
2014-04-16 20:08 ` Gerhard Sittig
2014-04-17 4:59 ` Huang Shijie
2014-04-17 11:30 ` Marek Vasut
2014-04-17 13:41 ` Huang Shijie
2014-04-17 14:15 ` Marek Vasut
2014-04-17 15:55 ` Gerhard Sittig
2014-04-17 15:57 ` Huang Shijie
2014-04-17 18:12 ` Marek Vasut
2014-04-16 23:40 ` Marek Vasut
2014-04-17 5:01 ` Huang Shijie [this message]
2014-04-17 11:32 ` Marek Vasut
2014-04-17 12:59 ` Huang Shijie
2014-04-17 14:15 ` Marek Vasut
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140417050123.GC29495@localhost \
--to=b32955@freescale.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox