From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-out.m-online.net ([212.18.0.10])
 by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux))
 id 1WaoVb-0007Et-Sy
 for linux-mtd@lists.infradead.org; Thu, 17 Apr 2014 15:45:52 +0000
From: Marek Vasut <marex@denx.de>
To: Huang Shijie <shijie8@gmail.com>
Subject: Re: [PATCH] mtd: spi-nor: fix the wrong dummy value
Date: Thu, 17 Apr 2014 16:15:12 +0200
References: <1397636299-2390-1-git-send-email-b32955@freescale.com>
 <20140416200849.GO3528@book.gsilab.sittig.org>
 <20140417134127.GA3980@localhost.localdomain>
In-Reply-To: <20140417134127.GA3980@localhost.localdomain>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="us-ascii"
Content-Transfer-Encoding: 7bit
Message-Id: <201404171615.12880.marex@denx.de>
Cc: Huang Shijie <b32955@freescale.com>, Gerhard Sittig <gsi@denx.de>,
 computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
 dwmw2@infradead.org
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On Thursday, April 17, 2014 at 03:41:29 PM, Huang Shijie wrote:
> On Wed, Apr 16, 2014 at 10:08:49PM +0200, Gerhard Sittig wrote:
> > On Wed, 2014-04-16 at 16:18 +0800, Huang Shijie wrote:
> > > The dummy cycles is actually 8 for SPI fast/dual/quad read.
> > > 
> > > This patch fixes the wrong dummy value for both the spi-nor.c and
> > > m25p80.c.
> > > 
> > > Signed-off-by: Huang Shijie <b32955@freescale.com>
> > > ---
> > > 
> > >  drivers/mtd/devices/m25p80.c  |    3 +++
> > >  drivers/mtd/spi-nor/spi-nor.c |    2 +-
> > >  2 files changed, 4 insertions(+), 1 deletions(-)
> > > 
> > > diff --git a/drivers/mtd/devices/m25p80.c
> > > b/drivers/mtd/devices/m25p80.c index 1557d8f..112ca8b 100644
> > > --- a/drivers/mtd/devices/m25p80.c
> > > +++ b/drivers/mtd/devices/m25p80.c
> > > @@ -131,6 +131,9 @@ static int m25p80_read(struct spi_nor *nor, loff_t
> > > from, size_t len,
> > > 
> > >  	int dummy = nor->read_dummy;
> > >  	int ret;
> > > 
> > > +	/* convert the dummy cycles to the number of byte */
> > > +	dummy >>= 3;
> > > +
> > 
> > "dummy /= 8" to match the comment / commit message, and for
> > better mental association with a byte's width and the below
> > return value?
> 
> The disassemble code for "int dummy = 8; dummy /= 8;" is:
> --------------------------------------------------
>     83a6:	2308      	movs	r3, #8
>     83a8:	607b      	str	r3, [r7, #4]
>     83aa:	687b      	ldr	r3, [r7, #4]
>     83ac:	1dda      	adds	r2, r3, #7
>     83ae:	2b00      	cmp	r3, #0
>     83b0:	bfb4      	ite	lt
>     83b2:	4613      	movlt	r3, r2
>     83b4:	461b      	movge	r3, r3
>     83b6:	10db      	asrs	r3, r3, #3
>     83b8:	607b      	str	r3, [r7, #4]
> --------------------------------------------------
> 
> The disassemble code for "int dummy = 8; dummy >>= 3;" is:
> --------------------------------------------------
>     83a6:	2308      	movs	r3, #8
>     83a8:	607b      	str	r3, [r7, #4]
>     83aa:	687b      	ldr	r3, [r7, #4]
>     83ac:	10db      	asrs	r3, r3, #3
>     83ae:	607b      	str	r3, [r7, #4]
> --------------------------------------------------
> 
> Obviously, the "dummy >>= 3" is faster then "dummy /= 8".

Which GCC compiler is that please ? I'm surprised GCC doesn't optimize it.

Best regards,
Marek Vasut