Re: [RFC PATCH] mtd: spi-nor: add DDR quad read support

[Marek Vasut <marex@denx.de>]

On Thursday, April 17, 2014 at 06:05:17 PM, Huang Shijie wrote:
> On Thu, Apr 17, 2014 at 04:24:36PM +0200, Marek Vasut wrote:
> > On Wednesday, April 16, 2014 at 11:47:21 AM, Huang Shijie wrote:
> > [...]
> > 
> > > @@ -74,6 +74,11 @@ static int read_cr(struct spi_nor *nor)
> > > 
> > >  static inline int spi_nor_read_dummy_cycles(struct spi_nor *nor)
> > >  {
> > >  
> > >  	switch (nor->flash_read) {
> > > 
> > > +	case SPI_NOR_DDR_QUAD:
> > > +		/*
> > > +		 * We set 8 for the DDR Quad read, the SPI NOR controller
> > > +		 * can change it to 6 or 4 with DeviceTree property.
> > > +		 */
> > 
> > Isn't the number of dummy cycles a property of the chip ?
> 
> I want to add DT node, such as "ddr_quad_read_dummy".
> But I do not know which Document file to put the DT node to.
> 
> the spi-bus.txt ? or the spi-nor.txt?

It's a property of the chip, therefore spi-nor.txt , no ?
[...]

I replied about the failing-to-lower-mode in the other email.

Best regards,
Marek Vasut