Re: [PATCH V3] Add support for flag status register on Micron chips.

Graham Moore
2014-04-22T19:25:17Z

On Tue, Apr 22, 2014 at 1:45 PM, Gerhard Sittig <gsi@denx.de> wrote:
> the patch appears to not have dev_err() references, were they
> removed? see below
[...]
> this emits a message that an error has occured, but doesn't tell
> where it occured -- can you dev_err() here to make the message
> even more helpful?

Yeah, the previous dev_err was actually copy-pasted from a similar
function that already existed. When I rebased to l2-mtd/spinor, I did
the same copy-paste but that branch has pr_err instead of dev_err.
I'm a noob, so I didn't want to change things without a good
explanation :) On the other hand, I'm in favor of using dev_err
instead.

[...]
> this logic always returns "timed out" when the ready flag is not
> seen, even in the case of read errors -- can you "preset" the
> error code with "timed out", and update it with something more
> appropriate before returning when other errors are seen?
>
> though this is an internal helper, and callers may not tell the
> situations apart in the first place, so this might be a minor nit

Same here as above, copy-pasted, and so the logic is what already
existed. I double-checked the calling code, and like you say, the
callers do not tell the situations apart. About half the calls assume
any error is timeout. The others either pass return value or some
other error up, or they ignore it.

Thanks,
Graham