Re: [PATCH v3 1/9] mtd: nand: define struct nand_timings

Lee Jones
2014-05-08T14:30:02Z

> > Define a struct containing the standard NAND timings as described in NAND
> > datasheets.
> >
> > Signed-off-by: Boris BREZILLON <b.brezillon.dev@gmail.com>
> > ---
> > include/linux/mtd/nand.h | 49 ++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 49 insertions(+)
> >
> > diff --git a/include/linux/mtd/nand.h b/include/linux/mtd/nand.h
> > index 389b3c5..f3ff3a3 100644
> > --- a/include/linux/mtd/nand.h
> > +++ b/include/linux/mtd/nand.h

[...]

> > + * Parameters)
>
> Please document the units for these fields here. It looks like you're
> using picoseconds.

Can't we leave this open to interpretation? For instance, it's more
convenient for our driver to handle these as nano second values.

> > + *
> > + */
> > +
>
> Extra blank line.
>
> > +struct nand_sdr_timings {
> > + u32 tALH_min;
> > + u32 tADL_min;
> > + u32 tALS_min;
> > + u32 tAR_min;
> > + u32 tCEA_max;
> > + u32 tCEH_min;
> > + u32 tCH_min;
> > + u32 tCHZ_max;
> > + u32 tCLH_min;
> > + u32 tCLR_min;
> > + u32 tCLS_min;
> > + u32 tCOH_min;
> > + u32 tCS_min;

u32 tCSD_min;

> > + u32 tDH_min;
> > + u32 tDS_min;
> > + u32 tFEAT_max;
> > + u32 tIR_min;
> > + u32 tITC_max;

u32 tR_max;

> > + u32 tRC_min;
> > + u32 tREA_max;
> > + u32 tREH_min;
> > + u32 tRHOH_min;
> > + u32 tRHW_min;
> > + u32 tRHZ_max;
> > + u32 tRLOH_min;
> > + u32 tRP_min;
> > + u32 tRR_min;
> > + u64 tRST_max;
> > + u32 tWB_max;
> > + u32 tWC_min;
> > + u32 tWH_min;
> > + u32 tWHR_min;
> > + u32 tWP_min;
> > + u32 tWW_min;
> > +};
> > +
> > #endif /* __LINUX_MTD_NAND_H */

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog