From: Brian Norris <computersforpeace@gmail.com>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH] mtd: denali: fix write_oob_data() function
Date: Fri, 9 May 2014 19:12:26 -0700 [thread overview]
Message-ID: <20140510021226.GI28907@ld-irv-0074> (raw)
In-Reply-To: <1397730174-4763-1-git-send-email-yamada.m@jp.panasonic.com>
On Thu, Apr 17, 2014 at 07:22:54PM +0900, Masahiro Yamada wrote:
> Since write_oob_data is calling denali_send_pipeline_cmd()
> with access_type=SPARE_ACCESS, this might has no impact.
"Might"? Are you sure? Do you have any test results? I don't want to
change this code based on a whim...
> But calling it with tranfser_spare=false looks weird because
> write_oob_data() is the function for transferring the spare area.
>
> Signed-off-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
> ---
> drivers/mtd/nand/denali.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
> index c07cd57..a55b9d4 100644
> --- a/drivers/mtd/nand/denali.c
> +++ b/drivers/mtd/nand/denali.c
> @@ -841,7 +841,7 @@ static int write_oob_data(struct mtd_info *mtd, uint8_t *buf, int page)
>
> denali->page = page;
>
> - if (denali_send_pipeline_cmd(denali, false, false, SPARE_ACCESS,
> + if (denali_send_pipeline_cmd(denali, false, true, SPARE_ACCESS,
> DENALI_WRITE) == PASS) {
> write_data_to_flash_mem(denali, buf, mtd->oobsize);
>
Brian
next prev parent reply other threads:[~2014-05-10 2:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-17 10:22 [PATCH] mtd: denali: fix write_oob_data() function Masahiro Yamada
2014-05-10 2:12 ` Brian Norris [this message]
2014-05-16 6:36 ` Masahiro Yamada
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140510021226.GI28907@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox