From: Luka Perkov <luka@openwrt.org>
To: John Crispin <john@phrozen.org>
Cc: Richard Weinberger <richard.weinberger@gmail.com>,
John Crispin <blogic@openwrt.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] UBI: add a ubi forced detach ioctl
Date: Mon, 12 May 2014 12:44:00 +0200 [thread overview]
Message-ID: <20140512104400.GA24995@w500.lan> (raw)
In-Reply-To: <53709292.6070600@phrozen.org>
On Mon, May 12, 2014 at 11:21:22AM +0200, John Crispin wrote:
> This is a ugly temporary patch that we carry around in openwrt until we
> have a real fix. why are you trying to upstream this ?
I didn't think this is a hack, other file systems can force umount as
well. What are you proposing as a real fix?
> Additionally the patch was written by Daniel and not me so the SoB is
> wrong.
I took it from OpenWrt and it was commited there with your SoB and
Daniel was not mentioned there.
> On 12/05/2014 09:14, Richard Weinberger wrote:
> > On Mon, May 12, 2014 at 1:17 AM, Luka Perkov <luka@openwrt.org>
> > wrote:
> >> From: John Crispin <blogic@openwrt.org>
> >>
> >> Signed-off-by: John Crispin <blogic@openwrt.org> Tested-by: Luka
> >> Perkov <luka@openwrt.org> CC: Artem Bityutskiy
> >> <dedekind1@gmail.com>
> >
> > The changelog fails to describe why you need this new ioctl() and
> > what problem this patch is solving.
When running ubi rootfs upgrade on nand based OpenWrt device after
pivot_root init process is still "hooked" on the old file system. Thus,
the old file system can not be umounted. If the filesystem is mounted it
can not be upgraded with using for example ubiupdatevol or removed with
ubirmvol. Forcing umount would allow to run the before mentioned
commands.
Luka
next prev parent reply other threads:[~2014-05-12 10:44 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-11 23:17 [PATCH] UBI: add a ubi forced detach ioctl Luka Perkov
2014-05-12 7:14 ` Richard Weinberger
2014-05-12 9:21 ` John Crispin
2014-05-12 10:44 ` Luka Perkov [this message]
2014-05-12 13:47 ` Richard Weinberger
2014-05-12 14:30 ` Luka Perkov
2014-05-13 9:03 ` Artem Bityutskiy
2014-05-13 9:09 ` John Crispin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512104400.GA24995@w500.lan \
--to=luka@openwrt.org \
--cc=blogic@openwrt.org \
--cc=dedekind1@gmail.com \
--cc=john@phrozen.org \
--cc=linux-mtd@lists.infradead.org \
--cc=richard.weinberger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox