From: Brian Norris <computersforpeace@gmail.com>
To: Pekon Gupta <pekon@ti.com>
Cc: Stefan Roese <sr@denx.de>,
linux-mtd <linux-mtd@lists.infradead.org>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Subject: Re: [PATCH v2] mtd: nand: omap: fix BCHx ecc.correct to return detected bit-flips in erased-page
Date: Mon, 12 May 2014 13:36:26 -0700 [thread overview]
Message-ID: <20140512203626.GS28907@ld-irv-0074> (raw)
In-Reply-To: <1395730699-14687-1-git-send-email-pekon@ti.com>
On Tue, Mar 25, 2014 at 12:28:19PM +0530, Pekon Gupta wrote:
> fixes: commit 62116e5171e00f85a8d53f76e45b84423c89ff34
> mtd: nand: omap2: Support for hardware BCH error correction.
>
> In omap_elm_correct_data(), if bitflip_count in an erased-page is within the
> correctable limit (< ecc.strength), then it is not indicated back to the caller
> ecc->read_page().
> This mis-guides upper layers like MTD and UBIFS layer to assume erased-page as
> perfectly clean and use it for writing even if actual bitflip_count was
> dangerously high (bitflip_count > mtd->bitflip_threshold).
>
> This patch fixes this above issue, by returning 'stats' to caller
> ecc->read_page() under all scenarios.
>
> Reported-by: Brian Norris <computersforpeace@gmail.com>
> Signed-off-by: Pekon Gupta <pekon@ti.com>
Pushed to l2-mtd.git. Thanks!
Brian
next prev parent reply other threads:[~2014-05-12 20:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-25 6:58 [PATCH v2] mtd: nand: omap: fix BCHx ecc.correct to return detected bit-flips in erased-page Pekon Gupta
2014-03-25 7:05 ` Gupta, Pekon
2014-04-23 6:29 ` Gupta, Pekon
2014-05-12 20:36 ` Brian Norris [this message]
2014-05-19 5:00 ` Gupta, Pekon
2014-05-19 12:20 ` Ezequiel Garcia
2014-05-20 4:43 ` Gupta, Pekon
2014-05-20 23:42 ` Brian Norris
2014-05-22 17:56 ` Gupta, Pekon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512203626.GS28907@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox