From: Brian Norris <computersforpeace@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-mtd@lists.infradead.org,
Kyungmin Park <kyungmin.park@samsung.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] mtd/onenand: fix build warning for dma type
Date: Mon, 12 May 2014 16:26:53 -0700 [thread overview]
Message-ID: <20140512232653.GV28907@ld-irv-0074> (raw)
In-Reply-To: <1399560990-1402858-3-git-send-email-arnd@arndb.de>
On Thu, May 08, 2014 at 04:56:14PM +0200, Arnd Bergmann wrote:
> The samsung onenand driver passes around a dma address token
> through a void pointer, which is incorrect and leads to
> warnings like this one:
>
> onenand/samsung.c:548:2: warning: passing argument 1 of '__fswab32' makes integer from pointer without a cast [enabled by default]
> writel(src, base + S5PC110_DMA_SRC_ADDR);
> ^
>
> This patch makes it use dma_addr_t here, which is more appropriate.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: David Woodhouse <dwmw2@infradead.org>
> Cc: Brian Norris <computersforpeace@gmail.com>
> Cc: linux-mtd@lists.infradead.org
Pushed this one to l2-mtd.git. Thanks!
I think the second MTD patch is still under discussion, right? I'll
follow up there if necessary.
Brian
next prev parent reply other threads:[~2014-05-12 23:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 14:46 [PATCH 00/22] Random ARM randconfig fixes in drivers Arnd Bergmann
[not found] ` <1399560990-1402858-1-git-send-email-arnd@arndb.de>
2014-05-08 14:56 ` [PATCH 1/2] mtd/onenand: fix build warning for dma type Arnd Bergmann
2014-05-12 23:26 ` Brian Norris [this message]
2014-05-08 14:56 ` [PATCH 2/2] mtd: orion-nand: fix build error with ARMv4 Arnd Bergmann
2014-05-09 18:45 ` Ezequiel Garcia
2014-05-09 19:29 ` Geert Uytterhoeven
2014-05-09 20:12 ` Arnd Bergmann
2014-05-09 21:28 ` Jason Gunthorpe
2014-05-09 22:09 ` Ezequiel Garcia
2014-05-09 22:24 ` Arnd Bergmann
2014-05-09 23:55 ` Ezequiel Garcia
2014-05-13 20:55 ` Jason Gunthorpe
2014-05-14 11:47 ` Arnd Bergmann
2014-05-14 12:35 ` Geert Uytterhoeven
2014-05-14 13:09 ` Arnd Bergmann
2014-05-08 16:41 ` [PATCH 00/22] Random ARM randconfig fixes in drivers Guenter Roeck
2014-05-09 11:48 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512232653.GV28907@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=arnd@arndb.de \
--cc=dwmw2@infradead.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox