From: Brian Norris <computersforpeace@gmail.com>
To: Scott Wood <scottwood@freescale.com>
Cc: Artem Bityutskiy <artem.bityutskiy@linux.intel.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Pekon Gupta <pekon@ti.com>,
Helmut Schaa <helmut.schaa@googlemail.com>
Subject: Re: [PATCH 1/1] mtd: eLBC NAND: fixes subpage write support
Date: Mon, 12 May 2014 16:49:00 -0700 [thread overview]
Message-ID: <20140512234900.GX28907@ld-irv-0074> (raw)
In-Reply-To: <1399504973.15726.356.camel@snotra.buserror.net>
On Wed, May 07, 2014 at 06:22:53PM -0500, Scott Wood wrote:
> On Tue, 2014-05-06 at 09:41 +0530, Pekon Gupta wrote:
> > As subpage write is enabled by default for all drivers, nand_write_subpage_hwecc
> > causes a crash if the driver did not register ecc->hwctl or ecc->calculate.
> > This behavior was introduced in
> > commit 837a6ba4f3b6d23026674e6af6b6849a4634fff9
> > "mtd: nand: subpage write support for hardware based ECC schemes".
> >
> > This fixes a crash by emulating subpage write support by padding sub-page data
> > with 0xff on either sides to make it full page compatible.
> >
> > CC: <stable@vger.kernel.org> # 3.10.x+
> >
> > Reported-by: Helmut Schaa <helmut.schaa@googlemail.com>
> > Tested-by: Helmut Schaa <helmut.schaa@googlemail.com>
> > Signed-off-by: Pekon Gupta <pekon@ti.com>
> > ---
> > drivers/mtd/nand/fsl_elbc_nand.c | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
>
> Reviewed-by: Scott Wood <scottwood@freescale.com>
Pushed to l2-mtd. Thanks!
Brian
prev parent reply other threads:[~2014-05-12 23:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-06 4:11 [PATCH 1/1] mtd: eLBC NAND: fixes subpage write support Pekon Gupta
2014-05-07 23:22 ` Scott Wood
2014-05-12 23:49 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140512234900.GX28907@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=artem.bityutskiy@linux.intel.com \
--cc=helmut.schaa@googlemail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox