Re: [PATCH 3/4] mtd: Introduce mtd_block_isreserved()

Ezequiel Garcia
2014-05-14T23:38:20Z

On 12 May 06:31 PM, Brian Norris wrote:
> On Fri, Mar 21, 2014 at 08:57:43AM -0300, Ezequiel Garcia wrote:
[..]
> >
> > +int mtd_block_isreserved(struct mtd_info *mtd, loff_t ofs)
> > +{
> > + if (!mtd->_block_isreserved)
> > + return 0;
> > + if (ofs < 0 || ofs > mtd->size)
> > + return -EINVAL;
>
> At first, I was going to recommend that the out-of-bounds check go
> before the !mtd->_block_isreserved check, since it's best to warn users
> for invalid input. But then, mtd_block_isbad() has the same ordering, so
> it'd be nice to consistent...
>
> Do we flip a coin to decide whether to change both or leave as-is? :)
>

Actually, I just followed the same convention as all the other functions,
not just mtd_block_isbad().

I'll add a patch changing them all so the parameters checking is done first.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering