From: Brian Norris <computersforpeace@gmail.com>
To: Vincenzo Aliberti <vincenzo.aliberti@gmail.com>
Cc: linux-mtd@lists.infradead.org, Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH v3] mtd: lpddr: add driver for LPDDR2-NVM PCM memories
Date: Wed, 14 May 2014 09:19:17 -0700 [thread overview]
Message-ID: <20140514161917.GJ28907@ld-irv-0074> (raw)
In-Reply-To: <CADBu1QsUj4m2Vz_Dot6HSp-dDJ8QDO6+PTgC1+6CW=r=-KjUYw@mail.gmail.com>
Hi,
On Wed, May 14, 2014 at 09:44:38AM +0200, Vincenzo Aliberti wrote:
> Hi Brian,
> your feedback looks great! Thanks!
>
> Only one concern: I have been forced to test it on a 3.10_rc4 version
> of the Kernel and in order to use
> IS_ERR and PTR_ERR functions I had to add:
>
> #include <linux/err.h>
>
> On the 3.14 I expect it should be the same, which is your feeling?
Yeah, I missed the #include. It must have been included implicitly by
another header. But it should be included explicitly.
> Do you wnat I send a v4 of this patch?
Please do.
Brian
next prev parent reply other threads:[~2014-05-14 16:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 21:19 [PATCH v3] mtd: lpddr: add driver for LPDDR2-NVM PCM memories Vincenzo Aliberti
2014-05-12 18:30 ` Brian Norris
2014-05-14 7:44 ` Vincenzo Aliberti
2014-05-14 16:19 ` Brian Norris [this message]
2014-05-15 21:19 ` [PATCH v4] " Vincenzo Aliberti
2014-05-21 0:46 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140514161917.GJ28907@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=vincenzo.aliberti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox