From: Dan Carpenter <dan.carpenter@oracle.com>
To: Brian Norris <computersforpeace@gmail.com>
Cc: Mike Frysinger <vapier.adi@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
kernel-janitors@vger.kernel.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Julia Lawall <julia.lawall@lip6.fr>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
Fabio Estevam <festevam@gmail.com>
Subject: Re: [PATCH 1/2] mtd: delete unneeded call to platform_get_drvdata
Date: Tue, 20 May 2014 12:15:26 +0300 [thread overview]
Message-ID: <20140520091526.GF15585@mwanda> (raw)
In-Reply-To: <20140520083531.GH2413@norris-Latitude-E6410>
On Tue, May 20, 2014 at 01:35:31AM -0700, Brian Norris wrote:
> > > > static int bf5xx_nand_resume(struct platform_device *dev)
> > > > {
> > > > - struct bf5xx_nand_info *info = platform_get_drvdata(dev);
> > > > -
> > > > return 0;
> > >
> > > In this case bf5xx_nand_suspend/resume could be removed?
> >
> > I don't know. It looks like it is intentional to have a definition that
> > returns an indication of success? The complete set of definitions is:
>
> I'm not so sure. I believe suspend/resume works just fine without the
> hooks, if those hooks would otherwise be doing nothing. It is notable
> that this driver is not using the modern dev_pm_ops form of the
> suspend/resume callbacks, so maybe it just hasn't aged gracefully--and
> possibly was never supported properly in the first place.
>
These are called from platform_legacy_suspend/platform_legacy_resume.
It looks like the functions are not needed.
(I am not an expert on pm, I just querried my Smatch Cross Function
Database which is awesome).
regards,
dan carpenter
prev parent reply other threads:[~2014-05-20 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-17 6:32 [PATCH 1/2] mtd: delete unneeded call to platform_get_drvdata Julia Lawall
2014-05-17 7:07 ` Fabio Estevam
2014-05-17 7:12 ` Julia Lawall
2014-05-20 8:35 ` Brian Norris
2014-05-20 9:15 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140520091526.GF15585@mwanda \
--to=dan.carpenter@oracle.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=festevam@gmail.com \
--cc=julia.lawall@lip6.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).