From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.karo-electronics.de ([81.173.242.67]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X07Cr-0006SX-T4 for linux-mtd@lists.infradead.org; Thu, 26 Jun 2014 10:47:06 +0000 Date: Thu, 26 Jun 2014 12:44:51 +0200 From: Lothar =?UTF-8?B?V2HDn21hbm4=?= To: Lothar =?UTF-8?B?V2HDn21hbm4=?= Subject: Re: [PATCHv4 0/5] mtd: gpmi: make blockmark swapping optional Message-ID: <20140626124451.6014fde3@ipc1.ka-ro> In-Reply-To: <1402579245-13377-1-git-send-email-LW@KARO-electronics.de> References: <1402579245-13377-1-git-send-email-LW@KARO-electronics.de> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: Mark Rutland , Boris BREZILLON , linux-doc@vger.kernel.org, Artem Bityutskiy , Wei Yongjun , linux-mtd@lists.infradead.org, Michael Grzeschik , Russell King , Arnd Bergmann , Jingoo Han , Shawn Guo , Ezequiel Garcia , Michael Opdenacker , Grant Likely , devicetree@vger.kernel.org, Sascha Hauer , Pawel Moll , Ian Campbell , Rob Herring , linux-arm-kernel@lists.infradead.org, Fabio Estevam , Brian Norris , linux-kernel@vger.kernel.org, Huang Shijie , Rob Landley , Kumar Gala , Shawn Guo , David Woodhouse List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi, Lothar Wa=C3=9Fmann wrote: > With a flash-based BBT there is no reason to move the Factory Bad > Block Marker from the data area buffer (to where it is mapped by the > GPMI NAND controller) to the OOB buffer. Thus, make this feature > configurable via DT. This is required for the Ka-Ro electronics > i.MX6 platforms. >=20 > Changes wrt. v2: > - added a warning for i.MX28 to the binding documentation > - fixed the gpmi_ecc_read_subpage() routine which turned on blockmark > swapping unconditionally > - use !GPMI_IS_MX23() in place of this->swap_block_mark (which were > synonymous the original code) in gpmi_ecc_read_oob() and > gpmi_block_markbad() > - make nand-on-flash-bbt a prerequisite for this feature >=20 > patch added: > - add an additional option to turn of BB mark writing >=20 > Changes wrt. v3: > - added two code cleanup patches > - added a patch to turn of NAND_BBT_CREATE, if blockmark swapping is disa= bled >=20 >=20 any comments on this patchset? Lothar Wa=C3=9Fmann --=20 ___________________________________________________________ Ka-Ro electronics GmbH | Pascalstra=C3=9Fe 22 | D - 52076 Aachen Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10 Gesch=C3=A4ftsf=C3=BChrer: Matthias Kaussen Handelsregistereintrag: Amtsgericht Aachen, HRB 4996 www.karo-electronics.de | info@karo-electronics.de ___________________________________________________________