From: "Guido Martínez" <guido@vanguardiasur.com.ar>
To: "Gupta, Pekon" <pekon@ti.com>
Cc: Tony Lindgren <tony@atomide.com>,
Jason Kridner <jkridner@gmail.com>,
linux-omap <linux-omap@vger.kernel.org>,
linux-mtd <linux-mtd@lists.infradead.org>,
Robert Nelson <robertcnelson@gmail.com>
Subject: Re: [PATCH v1 1/3] ARM: dts: am335x-bone: add support for beaglebone NAND cape
Date: Tue, 1 Jul 2014 20:42:19 -0300 [thread overview]
Message-ID: <20140701234219.GA27789@fox> (raw)
In-Reply-To: <20980858CB6D3A4BAE95CA194937D5E73EAF8874@DBDE04.ent.ti.com>
Hi Pekon,
On Tue, Jul 01, 2014 at 07:01:03AM +0000, Gupta, Pekon wrote:
> >http://lists.infradead.org/pipermail/linux-arm-kernel/2014-June/266966.html
> >
> I don't think we need above patch.
> Helper macro "for_each_available_child_of_node" internally takes care
> of skipping nodes with status="disabled".
>
> $KERNEL/include/linux/of.h
> #define for_each_available_child_of_node(parent, child) \
> for (child = of_get_next_available_child(parent, NULL); child != NULL; \
> child = of_get_next_available_child(parent, child))
>
> $KERNEL/drivers/of/base.c @@ of_get_next_available_child(...) {
> ...
> if (!__of_device_is_available(next))
> continue;
> ...
Yes, that's why I suggest using that macro. It's not currently used
in gpmc.c and my patch changes the 'for_each_child_of_node' to a
'for_each_available_child_of_node'. Or am I missing something?
Regards,
--
Guido Martínez, VanguardiaSur
www.vanguardiasur.com.ar
next prev parent reply other threads:[~2014-07-01 23:40 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-24 12:24 [PATCH v1 0/3] ARM: dts: am335x-bone: Beaglebone cape DTS Pekon Gupta
2014-06-24 12:24 ` [PATCH v1 1/3] ARM: dts: am335x-bone: add support for beaglebone NAND cape Pekon Gupta
2014-06-25 15:27 ` Ezequiel Garcia
2014-06-26 5:43 ` Gupta, Pekon
2014-06-26 10:40 ` Tony Lindgren
2014-06-26 15:06 ` Guido Martínez
2014-07-01 7:01 ` Gupta, Pekon
2014-07-01 23:42 ` Guido Martínez [this message]
2014-07-02 5:29 ` Gupta, Pekon
2014-06-26 19:48 ` Guido Martínez
2014-06-27 21:06 ` Gupta, Pekon
2014-07-01 8:47 ` Tony Lindgren
2014-07-01 9:07 ` Gupta, Pekon
2014-07-01 13:28 ` Tony Lindgren
2014-06-24 12:24 ` [PATCH v1 2/3] ARM: dts: am335x-bone: add support for beaglebone NOR cape Pekon Gupta
2014-06-24 12:24 ` [PATCH v1 3/3] ARM: dts: am335x-bone: add support for beaglebone LCD4 cape Pekon Gupta
2014-06-24 15:03 ` Ezequiel Garcia
2014-06-25 4:38 ` Gupta, Pekon
2014-06-25 14:59 ` Ezequiel Garcia
2014-06-24 15:24 ` Jason Kridner
2014-06-25 5:49 ` Gupta, Pekon
2014-06-26 4:30 ` Jason Kridner
2014-06-26 15:40 ` Guido Martínez
2014-06-26 18:35 ` Darren Etheridge
2014-06-27 11:38 ` Gupta, Pekon
-- strict thread matches above, loose matches on Subject: below --
2014-03-12 10:49 [PATCH v1 0/3] add parallel NAND support for TI's new OMAPx and AMxx platforms (Part-2) Pekon Gupta
2014-03-12 10:49 ` [PATCH v1 1/3] ARM: dts: am335x-bone: add support for beaglebone NAND cape Pekon Gupta
2014-03-12 14:35 ` Nishanth Menon
2014-03-12 18:26 ` Gupta, Pekon
2014-03-12 18:57 ` Nishanth Menon
2014-03-12 19:08 ` Robert Nelson
2014-03-12 19:28 ` Tony Lindgren
2014-03-12 20:51 ` Nishanth Menon
2014-03-12 21:13 ` Gupta, Pekon
2014-03-12 21:53 ` Nishanth Menon
2014-03-13 6:19 ` Gupta, Pekon
2014-03-13 13:03 ` Nishanth Menon
2014-03-13 13:30 ` Robert Nelson
2014-03-13 16:55 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140701234219.GA27789@fox \
--to=guido@vanguardiasur.com.ar \
--cc=jkridner@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=pekon@ti.com \
--cc=robertcnelson@gmail.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).