From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ie0-x229.google.com ([2607:f8b0:4001:c03::229]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1X5nNj-00021G-Tt for linux-mtd@lists.infradead.org; Sat, 12 Jul 2014 02:49:49 +0000 Received: by mail-ie0-f169.google.com with SMTP id tp5so1575983ieb.0 for ; Fri, 11 Jul 2014 19:49:26 -0700 (PDT) Date: Fri, 11 Jul 2014 19:49:23 -0700 From: Brian Norris To: Christian Riesch Subject: Re: [RESEND PATCH v4 0/4] mtd: cfi_cmdset_0002: Add OTP support for Micron M29EW NOR flashes Message-ID: <20140712024923.GO7537@ld-irv-0074> References: <817d0c27-e4a8-45e2-b2c8-89fe64256268@mary.at.omicron.at> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Cc: "linux-mtd@lists.infradead.org" List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Christian, On Mon, Jul 07, 2014 at 02:22:51PM +0200, Christian Riesch wrote: > On Mon, May 5, 2014 at 8:14 AM, Christian Riesch wrote: > > The first version of this patchset was posted to the list in February 2013. > > There were a few comments to these patches (from Artem), which I have > > addressed in separate patches (merged by you on March 9). > > > > Since there are no further objections against these patches (after a review > > time of more than a year), I would like to ask you to merge them as well. > > Since you didn't take this patchset for the 3.16 merge window, I'd > like to know if there is anything I should change here. Otherwise I > would like to ask you to apply this patchset. Overlooked again, sorry. > > > > Best regards, > > Christian > > > > > > This patchset adds support for the reading, writing, and locking of the > > one time programmable (OTP) memory of Micron M29EW NOR flashes. > > > > These flashes have a 256 byte OTP memory, which is called extended > > memory region in its datasheet. The flash is compatible to Spansion S29GL > > and Macronix MX29GL devices, so support for the OTP memory of these > > flashes should also be possible. > > > > Tests with this patchset were done with a single Micron M29EW device > > (512 Mbit, 16 bit) on a custom board with a Texas Instruments AM1808 > > system on chip. > > > > Prerequisites: > > - Applies on linux-mtd.git > > > > Changes for v2: > > - dropped one patch that changes the detection of M29EW devices, > > this patch is currently not required > > - added support for locking > > - fixed a few bugs in the loop that walks through the OTP memory > > > > Changes for v3: > > - Added retlet parameter to cfi_amdstd_get_{fact,user}_prot_info > > - Fixed partial write of words > > > > Changes for v4: > > - Updated prerequisites in cover letter > > > > Christian Riesch (4): > > mtd: cfi_cmdset_0002: Add support for reading OTP > > mtd: cfi_cmdset_0002: Invalidate cache after entering/exiting OTP > > memory > > mtd: cfi_cmdset_0002: Add support for writing OTP memory > > mtd: cfi_cmdset_0002: Add support for locking OTP memory > > > > drivers/mtd/chips/cfi_cmdset_0002.c | 350 +++++++++++++++++++++++++++++++++-- > > 1 file changed, 331 insertions(+), 19 deletions(-) Pushed to l2-mtd.git. Thanks! Brian