Re: [PATCH v3] mtd:nor:timeout:fix do_write_buffer() timeout error

Brian Norris
2014-07-15T07:28:49Z

Hi Bean,

On Tue, Jul 15, 2014 at 04:23:44AM +0000, Bean Huo wrote:
> Thanks for your warmly response about my patch.I have been waiting for your message too long.
> It's hard for me to give you a good reason that some flash's CFI parameter is non-zero,and
> incorrect.I just found that if flash'buffer is 512 bytes,not 256 bytes,timeout error will happen.
> If using CFI's timemout value,that is OK.But for cfi_cmdset_0001.c,it also use timeout value of CFI.
> The difference with mine is that if timeout value is not defined in the CFI,the default maxmum timeout
> value is 500000us.

I understand the points here. But this is just a timeout value, so it
isn't a big issue if it's a little too large; but it's a major problem if
it's too short. Since this is an aged driver, which has to accomodate
all sorts of potentially broken chips, I think a "minimum timeout" is a
good idea. And using the current timeout of 2ms (or larger) is fine. So
in pseudocode:

if (CFI_time_typ != 0 && CFI_time_max != 0)
timeout_max = CFI_time_typ + CFI_time_max;
else
timeout_max = 0;
timeout_max = max(timeout_max, 2000);

> Because my company's mailbox title exsits chinese words,and i sent this patch for
> many times,you don't have one response,so i thought that you maybe couldn't receive my email.later,i
> chose my personal email.

It is reasonable to worry about bounced mail occasionally. If the
mailing list rejected your mail, you should get an automated message.
You can also check the archives soon after sending, to make sure your
mail shows up:

http://lists.infradead.org/pipermail/linux-mtd/

And for LKML email, you can check one of several archives mirrors, like
lkml.org.

> For this patch,i will do some changes,please every maintainer and commit-signer check.

Yes, please send a new version (version 4 now?). But please double check
your patch submission, so that it applies correctly this time.

Thanks,
Brian