* Re: [PATCH] mtd: spi-nor: Correct device-id for n25q512a device [not found] <1404795285-2929-1-git-send-email-Priyanka.Jain@freescale.com> @ 2014-07-08 7:38 ` Geert Uytterhoeven 2014-07-30 4:14 ` Brian Norris 0 siblings, 1 reply; 4+ messages in thread From: Geert Uytterhoeven @ 2014-07-08 7:38 UTC (permalink / raw) To: Priyanka Jain; +Cc: MTD Maling List, linux-spi CC linux-mtd On Tue, Jul 8, 2014 at 6:54 AM, Priyanka Jain <Priyanka.Jain@freescale.com> wrote: > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com> > --- > drivers/mtd/spi-nor/spi-nor.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > index c713c86..148bb51d 100644 > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -487,7 +487,7 @@ const struct spi_device_id spi_nor_ids[] = { > { "n25q128a11", INFO(0x20bb18, 0, 64 * 1024, 256, 0) }, > { "n25q128a13", INFO(0x20ba18, 0, 64 * 1024, 256, 0) }, > { "n25q256a", INFO(0x20ba19, 0, 64 * 1024, 512, SECT_4K) }, > - { "n25q512a", INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K) }, > + { "n25q512a", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K) }, > > /* PMC */ > { "pm25lv512", INFO(0, 0, 32 * 1024, 2, SECT_4K_PMC) }, > -- > 1.7.4.1 Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: spi-nor: Correct device-id for n25q512a device 2014-07-08 7:38 ` [PATCH] mtd: spi-nor: Correct device-id for n25q512a device Geert Uytterhoeven @ 2014-07-30 4:14 ` Brian Norris 2014-07-30 4:17 ` Priyanka Jain 0 siblings, 1 reply; 4+ messages in thread From: Brian Norris @ 2014-07-30 4:14 UTC (permalink / raw) To: Geert Uytterhoeven; +Cc: Priyanka Jain, MTD Maling List, linux-spi Hi Priyanka, On Tue, Jul 08, 2014 at 09:38:19AM +0200, Geert Uytterhoeven wrote: > CC linux-mtd (Thanks for forwarding, Geert) > On Tue, Jul 8, 2014 at 6:54 AM, Priyanka Jain > <Priyanka.Jain@freescale.com> wrote: > > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com> > > --- > > drivers/mtd/spi-nor/spi-nor.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c > > index c713c86..148bb51d 100644 > > --- a/drivers/mtd/spi-nor/spi-nor.c > > +++ b/drivers/mtd/spi-nor/spi-nor.c > > @@ -487,7 +487,7 @@ const struct spi_device_id spi_nor_ids[] = { > > { "n25q128a11", INFO(0x20bb18, 0, 64 * 1024, 256, 0) }, > > { "n25q128a13", INFO(0x20ba18, 0, 64 * 1024, 256, 0) }, > > { "n25q256a", INFO(0x20ba19, 0, 64 * 1024, 512, SECT_4K) }, > > - { "n25q512a", INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K) }, > > + { "n25q512a", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K) }, We can't just change the ID, as this would break other devices. Apparently there are multiple similar devices with at least two different IDs. And we already have this patch queued up in l2-mtd.git (also in linux-next): commit c14deddec1fbd8c9757c53a49dbfd2dc83265f21 Author: grmoore@altera.com <grmoore@altera.com> Date: Tue Apr 29 10:29:51 2014 -0500 mtd: spi-nor: add support for flag status register on Micron chips Feel free to test! > > > > /* PMC */ > > { "pm25lv512", INFO(0, 0, 32 * 1024, 2, SECT_4K_PMC) }, Brian ^ permalink raw reply [flat|nested] 4+ messages in thread
* RE: [PATCH] mtd: spi-nor: Correct device-id for n25q512a device 2014-07-30 4:14 ` Brian Norris @ 2014-07-30 4:17 ` Priyanka Jain 2014-07-30 4:26 ` Brian Norris 0 siblings, 1 reply; 4+ messages in thread From: Priyanka Jain @ 2014-07-30 4:17 UTC (permalink / raw) To: Brian Norris, Geert Uytterhoeven; +Cc: MTD Maling List, linux-spi Hello Brian, Should I send another patch which just add > > > + { "n25q512a", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K) }, And let the original one as it is ? Regards Priyanka > -----Original Message----- > From: Brian Norris [mailto:computersforpeace@gmail.com] > Sent: Wednesday, July 30, 2014 9:45 AM > To: Geert Uytterhoeven > Cc: Jain Priyanka-B32167; MTD Maling List; linux-spi > Subject: Re: [PATCH] mtd: spi-nor: Correct device-id for n25q512a device > > Hi Priyanka, > > On Tue, Jul 08, 2014 at 09:38:19AM +0200, Geert Uytterhoeven wrote: > > CC linux-mtd > > (Thanks for forwarding, Geert) > > > On Tue, Jul 8, 2014 at 6:54 AM, Priyanka Jain > > <Priyanka.Jain@freescale.com> wrote: > > > Signed-off-by: Priyanka Jain <Priyanka.Jain@freescale.com> > > > --- > > > drivers/mtd/spi-nor/spi-nor.c | 2 +- > > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > > > diff --git a/drivers/mtd/spi-nor/spi-nor.c > > > b/drivers/mtd/spi-nor/spi-nor.c index c713c86..148bb51d 100644 > > > --- a/drivers/mtd/spi-nor/spi-nor.c > > > +++ b/drivers/mtd/spi-nor/spi-nor.c > > > @@ -487,7 +487,7 @@ const struct spi_device_id spi_nor_ids[] = { > > > { "n25q128a11", INFO(0x20bb18, 0, 64 * 1024, 256, 0) }, > > > { "n25q128a13", INFO(0x20ba18, 0, 64 * 1024, 256, 0) }, > > > { "n25q256a", INFO(0x20ba19, 0, 64 * 1024, 512, SECT_4K) }, > > > - { "n25q512a", INFO(0x20bb20, 0, 64 * 1024, 1024, SECT_4K) }, > > > + { "n25q512a", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K) }, > > We can't just change the ID, as this would break other devices. > Apparently there are multiple similar devices with at least two different IDs. > And we already have this patch queued up in l2-mtd.git (also in linux-next): > > commit c14deddec1fbd8c9757c53a49dbfd2dc83265f21 > Author: grmoore@altera.com <grmoore@altera.com> > Date: Tue Apr 29 10:29:51 2014 -0500 > > mtd: spi-nor: add support for flag status register on Micron chips > > Feel free to test! > > > > > > > /* PMC */ > > > { "pm25lv512", INFO(0, 0, 32 * 1024, 2, SECT_4K_PMC) }, > > Brian ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] mtd: spi-nor: Correct device-id for n25q512a device 2014-07-30 4:17 ` Priyanka Jain @ 2014-07-30 4:26 ` Brian Norris 0 siblings, 0 replies; 4+ messages in thread From: Brian Norris @ 2014-07-30 4:26 UTC (permalink / raw) To: Priyanka Jain; +Cc: MTD Maling List, Geert Uytterhoeven, linux-spi On Tue, Jul 29, 2014 at 9:17 PM, Priyanka Jain <Priyanka.Jain@freescale.com> wrote: > Should I send another patch which just add >> > > + { "n25q512a", INFO(0x20ba20, 0, 64 * 1024, 1024, SECT_4K) }, > And let the original one as it is ? No. We already have this entry queued up for 3.17: + { "n25q512ax3", INFO(0x20ba20, 0, 64 * 1024, 1024, USE_FSR) }, Feel free to test it out. Brian ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-07-30 4:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1404795285-2929-1-git-send-email-Priyanka.Jain@freescale.com>
2014-07-08 7:38 ` [PATCH] mtd: spi-nor: Correct device-id for n25q512a device Geert Uytterhoeven
2014-07-30 4:14 ` Brian Norris
2014-07-30 4:17 ` Priyanka Jain
2014-07-30 4:26 ` Brian Norris
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox