From: Brian Norris <computersforpeace@gmail.com>
To: Samarth Parikh <samarthp@ymail.com>
Cc: "dwmw2@infradead.org" <dwmw2@infradead.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] Drivers: MTD: Fixed checkpatch seq_printf warnings
Date: Mon, 4 Aug 2014 14:27:57 -0700 [thread overview]
Message-ID: <20140804212757.GF3711@ld-irv-0074> (raw)
In-Reply-To: <1405968570.83800.YahooMailNeo@web192501.mail.sg3.yahoo.com>
On Tue, Jul 22, 2014 at 02:49:30AM +0800, Samarth Parikh wrote:
> Fixed checkpatch warnings: "WARNING: Prefer seq_puts to seq_printf"
>
>
>
>
> This patch is created with reference to the ongoing lkml thread
> https://lkml.org/lkml/2014/7/15/646
> where Andrew Morton wrote:
>
> "
> - puts is presumably faster
>
> - puts doesn't go rogue if you accidentally pass it a "%".
>
> - this patch would actually make compiled object files few bytes smaller.
> Perhaps because seq_printf() is a varargs function, forcing the
> caller to pass args on the stack instead of in registers.
> "
>
> Signed-off-by: Samarth Parikh <samarthp@ymail.com>
Queued to l2-mtd.git/next.
Brian
prev parent reply other threads:[~2014-08-04 21:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1405519230-48409-1-git-send-email-samarthp@ymail.com>
2014-07-21 18:49 ` [PATCH] Drivers: MTD: Fixed checkpatch seq_printf warnings Samarth Parikh
2014-08-04 21:27 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140804212757.GF3711@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=samarthp@ymail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox