From: Brian Norris <computersforpeace@gmail.com>
To: linux-mtd@lists.infradead.org
Cc: Bean Huo <beanhuo@outlook.com>,
Christian Riesch <christian.riesch@omicron.at>
Subject: Re: [PATCH] mtd: cfi_cmdset_0002: allow retry/timeout loop to exit
Date: Tue, 5 Aug 2014 14:53:05 -0700 [thread overview]
Message-ID: <20140805215305.GK3711@ld-irv-0074> (raw)
In-Reply-To: <1405994779-19207-1-git-send-email-computersforpeace@gmail.com>
On Mon, Jul 21, 2014 at 07:06:19PM -0700, Brian Norris wrote:
> The variable 'retries' is never modified, so if the reset operation
> never is going to complete, we'll get stuck in an infinite loop.
>
> It looks like the intention was to decrement 'retries' on every loop.
> Untested.
>
> Caught by Coverity.
>
> Signed-off-by: Brian Norris <computersforpeace@gmail.com>
Pushed this and my other Coverity-inspired patches to l2-mtd.git/next.
Brian
prev parent reply other threads:[~2014-08-05 21:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-07-22 2:06 [PATCH] mtd: cfi_cmdset_0002: allow retry/timeout loop to exit Brian Norris
2014-08-05 21:53 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805215305.GK3711@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=beanhuo@outlook.com \
--cc=christian.riesch@omicron.at \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox