From: Brian Norris <computersforpeace@gmail.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: linux-mtd@lists.infradead.org
Subject: Re: [PATCH v2] mtd: atmel_nand: NFC: fix mtd_nandbiterrs.ko test fail when using sram write
Date: Tue, 5 Aug 2014 15:09:02 -0700 [thread overview]
Message-ID: <20140805220902.GL3711@ld-irv-0074> (raw)
In-Reply-To: <1407235132-4757-1-git-send-email-josh.wu@atmel.com>
On Tue, Aug 05, 2014 at 06:38:52PM +0800, Josh Wu wrote:
> When enable NFC sram write, it will failed the mtd_nandbiterrs.ko test.
>
> As in driver's nfc_sram_write_page(), if ops->mode equal to MTD_OSP_RAW,
> driver assumes the data buffer contains one page data and one oob data
> followed. And driver will write the page data and oob data to nand.
>
> But this is wrong implementation. Since the data buffer don't contains the
> oob data to write. We should write the chip->oob_poi to nand's oob.
>
> So this patch fix it by writing the oob data from chip->oob_poi.
>
> Signed-off-by: Josh Wu <josh.wu@atmel.com>
> ---
> v1 -> v2:
> drop the sanity check for if write_page will write more than 1 page. As
> NAND layer will guarantees that.
Queued to l2-mtd.git/next. Thanks!
Brian
prev parent reply other threads:[~2014-08-05 22:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-05 10:38 [PATCH v2] mtd: atmel_nand: NFC: fix mtd_nandbiterrs.ko test fail when using sram write Josh Wu
2014-08-05 22:09 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140805220902.GL3711@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=josh.wu@atmel.com \
--cc=linux-mtd@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).