Re: [PATCH 7/7] mtd: denali: fix indentations and other trivial things

Sudip Mukherjee
2014-09-08T10:00:57Z

On Mon, Sep 08, 2014 at 06:14:48PM +0900, Masahiro Yamada wrote:
> Hi Josh,
>
>
> On Mon, 8 Sep 2014 01:39:20 -0700
> Josh Triplett <josh@joshtriplett.org> wrote:
>
> > On Mon, Sep 08, 2014 at 05:10:13PM +0900, Masahiro Yamada wrote:
> > > @@ -406,9 +404,9 @@ static void get_hynix_nand_para(struct denali_nand_info *denali,
> > > break;
> > > default:
> > > dev_warn(denali->dev,
> > > - "Spectra: Unknown Hynix NAND (Device ID: 0x%x)."
> > > - "Will use default parameter values instead.\n",
> > > - device_id);
> > > + "Spectra: Unknown Hynix NAND (Device ID: 0x%x)."
> > > + "Will use default parameter values instead.\n",
> > > + device_id);
> >
> > Please join quoted strings into a single line.
> >
> > > - pr_err("Your NAND chip OOB is not large enough to \
> > > - contain 8bit ECC correction codes");
> > > + pr_err("Your NAND chip OOB is not large enough to "
> > > + "contain 8bit ECC correction codes");
> >
> > Likewise.
> >
>
> Thanks for your review, but
> the quoted strings are too long to be joined into a single line.
> (exceed 80 columns)
>
These are user-visible strings and they can be more than 80 char.
If you see CodingStyle document , it is mentioned that :

However, never break user-visible strings such as printk messages, because that breaks the ability to grep for them.

thanks
sudip

>
> Best Regards
> Masahiro Yamada
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/