From: Masahiro Yamada <yamada.m@jp.panasonic.com>
To: Josh Triplett <josh@joshtriplett.org>
Cc: Jiri Kosina <trivial@kernel.org>,
Huang Shijie <shijie8@gmail.com>,
linux-kernel@vger.kernel.org,
Rashika Kheria <rashika.kheria@gmail.com>,
linux-mtd@lists.infradead.org,
"grmoore@altera.com" <grmoore@altera.com>,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH 7/7] mtd: denali: fix indentations and other trivial things
Date: Mon, 08 Sep 2014 18:14:48 +0900 [thread overview]
Message-ID: <20140908181447.C428.AA925319@jp.panasonic.com> (raw)
In-Reply-To: <20140908083920.GD5361@thin>
Hi Josh,
On Mon, 8 Sep 2014 01:39:20 -0700
Josh Triplett <josh@joshtriplett.org> wrote:
> On Mon, Sep 08, 2014 at 05:10:13PM +0900, Masahiro Yamada wrote:
> > @@ -406,9 +404,9 @@ static void get_hynix_nand_para(struct denali_nand_info *denali,
> > break;
> > default:
> > dev_warn(denali->dev,
> > - "Spectra: Unknown Hynix NAND (Device ID: 0x%x)."
> > - "Will use default parameter values instead.\n",
> > - device_id);
> > + "Spectra: Unknown Hynix NAND (Device ID: 0x%x)."
> > + "Will use default parameter values instead.\n",
> > + device_id);
>
> Please join quoted strings into a single line.
>
> > - pr_err("Your NAND chip OOB is not large enough to \
> > - contain 8bit ECC correction codes");
> > + pr_err("Your NAND chip OOB is not large enough to "
> > + "contain 8bit ECC correction codes");
>
> Likewise.
>
Thanks for your review, but
the quoted strings are too long to be joined into a single line.
(exceed 80 columns)
Best Regards
Masahiro Yamada
next prev parent reply other threads:[~2014-09-08 9:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-08 8:10 [PATCH 0/7] mtd: denali: A collection of trivial coding style fixes Masahiro Yamada
2014-09-08 8:10 ` [PATCH 1/7] mtd: denali: fix the format of comment blocks Masahiro Yamada
2014-09-08 8:29 ` Josh Triplett
2014-09-08 8:10 ` [PATCH 2/7] mtd: denali: remove unnecessary variable initializations Masahiro Yamada
2014-09-08 8:10 ` [PATCH 3/7] mtd: denali: remove unnecessary casts Masahiro Yamada
2014-09-08 8:10 ` [PATCH 4/7] mtd: denali: change the type of iterators to int Masahiro Yamada
2014-09-08 8:10 ` [PATCH 5/7] mtd: denali: remove a set-but-unused variable Masahiro Yamada
2014-09-08 8:30 ` Josh Triplett
2014-09-08 8:10 ` [PATCH 6/7] mtd: denali: remove unnecessary parentheses Masahiro Yamada
2014-09-08 8:34 ` Josh Triplett
2014-09-08 8:10 ` [PATCH 7/7] mtd: denali: fix indentations and other trivial things Masahiro Yamada
2014-09-08 8:39 ` Josh Triplett
2014-09-08 9:14 ` Masahiro Yamada [this message]
2014-09-08 10:00 ` Sudip Mukherjee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140908181447.C428.AA925319@jp.panasonic.com \
--to=yamada.m@jp.panasonic.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=grmoore@altera.com \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=rashika.kheria@gmail.com \
--cc=shijie8@gmail.com \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox