From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qc0-f172.google.com ([209.85.216.172]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XRhLs-000554-EQ for linux-mtd@lists.infradead.org; Wed, 10 Sep 2014 12:50:25 +0000 Received: by mail-qc0-f172.google.com with SMTP id o8so19579287qcw.3 for ; Wed, 10 Sep 2014 05:50:01 -0700 (PDT) Date: Wed, 10 Sep 2014 09:48:49 -0300 From: Ezequiel Garcia To: Roger Quadros Subject: Re: [PATCH 2/3] nand: omap2: Remove horrible ifdefs to fix module probe Message-ID: <20140910124849.GA25308@arch.hh.imgtec.org> References: <1410033389-32357-1-git-send-email-ezequiel@vanguardiasur.com.ar> <1410033389-32357-3-git-send-email-ezequiel@vanguardiasur.com.ar> <540D6CAB.7020501@ti.com> <540D8A92.2040209@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <540D8A92.2040209@ti.com> Cc: Tony Lindgren , Brian Norris , linux-mtd@lists.infradead.org, Guido =?iso-8859-1?Q?Mart=EDnez?= List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On 08 Sep 01:53 PM, Roger Quadros wrote: > On 09/08/2014 11:45 AM, Roger Quadros wrote: > > On 09/06/2014 10:56 PM, Ezequiel Garcia wrote: [..] > >> diff --git a/include/linux/platform_data/elm.h b/include/linux/platform_data/elm.h > >> index 780d1e9..25d1bca 100644 > >> --- a/include/linux/platform_data/elm.h > >> +++ b/include/linux/platform_data/elm.h > >> @@ -42,8 +42,22 @@ struct elm_errorvec { > >> int error_loc[16]; > >> }; > >> > >> +#if IS_ENABLED(CONFIG_MTD_NAND_OMAP_BCH) > > I still get the following error if I set CONFIG_MTD_NAND_OMAP2 to y and > CONFIG_MTD_NAND_OMAP_BCH to m. > > CONFIG_MTD_NAND_OMAP_BCH is used to select the ELM driver and it must be limited to > be built-in if CONFIG_MTD_NAND_OMAP2 is built-in. > Hm, yup. Any ideas on how to accomplish that? My Kconfig-foo is not strong enough :( -- Ezequiel Garcia, VanguardiaSur www.vanguardiasur.com.ar