From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: Boris BREZILLON <boris.brezillon@free-electrons.com>
Cc: Nicolas Ferre <nicolas.ferre@atmel.com>,
linux-kernel@vger.kernel.org,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] mtd: nand: atmel_nand: retrieve NFC clock
Date: Fri, 12 Sep 2014 00:05:00 +0200 [thread overview]
Message-ID: <20140912000500.5a1d5f75@free-electrons.com> (raw)
In-Reply-To: <20140911173854.73b201e7@bbrezillon>
Dear Boris BREZILLON,
On Thu, 11 Sep 2014 17:38:54 +0200, Boris BREZILLON wrote:
> > Anyway, with or without the docs I think this patch breaks DT backward
> > compatibility.
> >
> > Or am I missing something?
>
> Indeed, this block of code should be placed at the end of the probe
> function. I'll fix that.
>
> Note that if the clk is missing it just print a warning message and
> return 0, so after moving the code, it should not break DT backward
> compat ;-).
You may want to use:
dev_warn(FW_WARN "NFC clock missing, update your Device Tree\n");
Thomas
--
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
prev parent reply other threads:[~2014-09-11 22:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-11 14:43 [PATCH] mtd: nand: atmel_nand: retrieve NFC clock Alexandre Belloni
2014-09-11 15:20 ` Ezequiel Garcia
2014-09-11 15:38 ` Boris BREZILLON
2014-09-11 22:05 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140912000500.5a1d5f75@free-electrons.com \
--to=thomas.petazzoni@free-electrons.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox