Re: [PATCH v4 5/5] mtd: nand: Constrain omap_elm to built-in

Roger Quadros
2014-09-23T08:51:52Z

On 09/22/2014 09:58 PM, Brian Norris wrote:
> On Sat, Sep 20, 2014 at 05:53:16PM +0100, Ezequiel Garcia wrote:
>> This fixes the following build error when omap2_nand is chosen built-in,
>> and omap_elm is chosen as a module:
>>
>> drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
>> drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
>> drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
>> drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
>>
>> Fix this by making omap_elm a 'bool' driver.
>
> Hmm, so we're sacrificing a "feature" (that omap2 + omap_elm can both be
> built as modules) because we haven't solved one particular developer UI
> inconsistency (that we don't prevent the config combination of
> MTD_NAND_OMAP2=y and MTD_NAND_OMAP_BCH=m)? I wouldn't tend to sacrifice
> the feature for the sake of a bad config.
>
> Do you have any guesstimate as to whether the linker failure affects
> many people? Are people just hitting this with randconfig?

I think this issue was hit only during a manual menuconfig setting.

>
> Do you know if anyone ships loadable modules for this driver? e.g., any
> embedded distros?

Not sure about other distros but TI releases always set both
OMAP_NAND and OMAP_BCH as built-in.

cheers,
-roger

>
> I could go either way on this, but I just wasn't sure if these sorts of
> questions had been asked/answered.
>
>> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
>> ---
>> drivers/mtd/nand/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
>> index f1cf503..549c0cb 100644
>> --- a/drivers/mtd/nand/Kconfig
>> +++ b/drivers/mtd/nand/Kconfig
>> @@ -96,7 +96,7 @@ config MTD_NAND_OMAP2
>>
>> config MTD_NAND_OMAP_BCH
>> depends on MTD_NAND_OMAP2
>> - tristate "Support hardware based BCH error correction"
>> + bool "Support hardware based BCH error correction"
>> default n
>> select BCH
>> help
>
> Brian
>