Re: [PATCH v4 5/5] mtd: nand: Constrain omap_elm to built-in

Roger Quadros
2014-09-22T08:17:40Z

On 09/20/2014 07:53 PM, Ezequiel Garcia wrote:
> This fixes the following build error when omap2_nand is chosen built-in,
> and omap_elm is chosen as a module:
>
> drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
> drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
> drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
> drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
>
> Fix this by making omap_elm a 'bool' driver.
>
> Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

Acked-by: <rogerq@ti.com>

--
cheers,
-roger

> ---
> drivers/mtd/nand/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/nand/Kconfig b/drivers/mtd/nand/Kconfig
> index f1cf503..549c0cb 100644
> --- a/drivers/mtd/nand/Kconfig
> +++ b/drivers/mtd/nand/Kconfig
> @@ -96,7 +96,7 @@ config MTD_NAND_OMAP2
>
> config MTD_NAND_OMAP_BCH
> depends on MTD_NAND_OMAP2
> - tristate "Support hardware based BCH error correction"
> + bool "Support hardware based BCH error correction"
> default n
> select BCH
> help
>