Re: [PATCH v4 5/5] mtd: nand: Constrain omap_elm to built-in

Ezequiel Garcia
2014-09-22T19:16:41Z

[-- Attachment #1: Type: text/plain, Size: 1061 bytes --]

On 09/22/2014 03:58 PM, Brian Norris wrote:
> On Sat, Sep 20, 2014 at 05:53:16PM +0100, Ezequiel Garcia wrote:
>> This fixes the following build error when omap2_nand is chosen built-in,
>> and omap_elm is chosen as a module:
>>
>> drivers/mtd/nand/omap2.c:2010: undefined reference to `elm_config'
>> drivers/mtd/nand/omap2.c:1980: undefined reference to `elm_config'
>> drivers/mtd/nand/omap2.c:1927: undefined reference to `elm_config'
>> drivers/mtd/nand/omap2.c:1444: undefined reference to `elm_decode_bch_error_page'
>>
>> Fix this by making omap_elm a 'bool' driver.
>
> Hmm, so we're sacrificing a "feature" (that omap2 + omap_elm can both be
> built as modules) because we haven't solved one particular developer UI
> inconsistency (that we don't prevent the config combination of
> MTD_NAND_OMAP2=y and MTD_NAND_OMAP_BCH=m)? I wouldn't tend to sacrifice
> the feature for the sake of a bad config.
>

FWIW, I agree with you, as already said to Roger.
--
Ezequiel Garcia, VanguardiaSur
www.vanguardiasur.com.ar

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]