From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: pekon <pekon@pek-sem.com>,
linux-mtd@lists.infradead.org,
Brian Norris <computersforpeace@gmail.com>,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org,
Roger Quadros <rogerq@ti.com>
Subject: Re: [PATCH] nand: omap2: fix building with CONFIG_MTD_NAND_OMAP_BCH=m
Date: Wed, 1 Oct 2014 07:25:45 -0300 [thread overview]
Message-ID: <20141001102545.GB2085@arch.hh.imgtec.org> (raw)
In-Reply-To: <2306426.hFH1ds3Hiv@wuerfel>
On 01 Oct 12:13 PM, Arnd Bergmann wrote:
> On Wednesday 01 October 2014 13:07:51 Roger Quadros wrote:
> > On 10/01/2014 12:56 PM, Arnd Bergmann wrote:
> > > On Wednesday 01 October 2014 12:32:09 Roger Quadros wrote:
> > >>
> > >> With this patch NAND probe on DRA7xx fails like so
> > >>
> > >> [ 2.077313] omap-gpmc 50000000.gpmc: GPMC revision 6.0
> > >> [ 2.083842] nand: device found, Manufacturer ID: 0x2c, Chip ID: 0xca
> > >> [ 2.090524] nand: Micron MT29F2G16ABAEAWP
> > >> [ 2.094728] nand: 256MiB, SLC, page size: 2048, OOB size: 64
> > >> [ 2.100745] nand: using OMAP_ECC_BCH8_CODE_HW ECC scheme
> > >> [ 2.109764] omap2-nand: probe of omap2-nand.0 failed with error -38
> > >>
> > >> OMAP NAND driver is the only user of the ELM module and we want it
> > >> to be usable in all possible configurations when enabled.
> > >
> > > I don't understand. Is the BCH driver optional or not?
> > >
> > It is optional. If it is disabled we error out on platforms that have
> > the ELM IP. But if it is enabled, we don't want to fail probe on such platforms.
>
> Wouldn't it be better to treat the absence of the ELM driver the
> same way as the absence of the ELM hardware?
>
Indeed, it would be better to provide a fallback to the non-ELM behavior
if *anything* prevents initializing it.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-10-01 10:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-30 12:04 [PATCH] nand: omap2: fix building with CONFIG_MTD_NAND_OMAP_BCH=m Arnd Bergmann
2014-10-01 9:32 ` Roger Quadros
2014-10-01 9:56 ` Arnd Bergmann
2014-10-01 10:07 ` Roger Quadros
2014-10-01 10:13 ` Arnd Bergmann
2014-10-01 10:24 ` Roger Quadros
2014-10-01 10:25 ` Ezequiel Garcia [this message]
2014-10-01 10:24 ` Ezequiel Garcia
2014-10-01 10:46 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141001102545.GB2085@arch.hh.imgtec.org \
--to=ezequiel.garcia@free-electrons.com \
--cc=arnd@arndb.de \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@pek-sem.com \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox