From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pd0-x22e.google.com ([2607:f8b0:400e:c02::22e]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1XeXcp-00029n-3I for linux-mtd@lists.infradead.org; Wed, 15 Oct 2014 23:04:59 +0000 Received: by mail-pd0-f174.google.com with SMTP id y13so2059789pdi.33 for ; Wed, 15 Oct 2014 16:04:37 -0700 (PDT) Date: Wed, 15 Oct 2014 16:04:34 -0700 From: Brian Norris To: Artem Bityutskiy Subject: Re: [PATCH] nandsim: add id_bytes module parameter Message-ID: <20141015230434.GZ1193@ld-irv-0074> References: <1407713341-4446-1-git-send-email-akinobu.mita@gmail.com> <1413208135.7906.24.camel@sauron.fi.intel.com> <1413214845.7906.53.camel@sauron.fi.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1413214845.7906.53.camel@sauron.fi.intel.com> Cc: linux-mtd@lists.infradead.org, David Woodhouse , Akinobu Mita List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Oct 13, 2014 at 06:40:45PM +0300, Artem Bityutskiy wrote: > On Mon, 2014-10-13 at 16:48 +0300, Artem Bityutskiy wrote: > > On Mon, 2014-08-11 at 08:29 +0900, Akinobu Mita wrote: > > > nandsim can simulate NAND Flash which returns the ID bytes specified > > > by first_id_byte, ..., fourth_id_byte module parameters. > > > > > > In order to simulate NAND flash which returns more than four ID bytes, > > > this adds id_bytes module parameter which is specified by the array of > > > byte like this: > > > > > > # modprobe nandsim id_bytes=0x98,0xdc,0x90,0x26,0x76,0x15,0x01,0x08 bch=1 > > > > > > This doesn't add fifth_id_byte, ..., seventh_id_byte module parameters, > > > becuase they are redundant. But the existing first_id_byte, ..., > > > fourth_id_byte module parameters are preserved. > > > > Hi, I missed this patch, sorry. It looks good to me, I'll take it to my > > tree. > > Actually, let's merge this via the l2-mtd.git tree. Brian, what do you > think about this patch? It looks good for me in general, but I did not > review it line-by-line. The only thing is that the 'modinfo nandsim' may > look confusing for the user, who sees so many ID-related parameters, so > I'd add an "(obsolete)" marker to the string describing the old > parameters. But this is a minor thing, I did not want to ask Akinobu > about this because the patch was already waiting for very long time, I'd > do this myself while merging. Sorry, I really don't have the time to review every single patch these days. I had briefly looked at this patch previously and thought it was a good idea, but like you, I didn't look through all the code. I'll try to queue this up after the merge window, unless I discover something that really must be improved. Brian