From: Mark Rutland <mark.rutland@arm.com>
To: Josh Wu <josh.wu@atmel.com>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Pawel Moll <Pawel.Moll@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"nicolas.ferre@atmel.com" <nicolas.ferre@atmel.com>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"voice.shen@atmel.com" <voice.shen@atmel.com>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>
Subject: Re: [PATCH v3] mtd: atmel_nand: make PMECC lookup table and offset property optional
Date: Thu, 16 Oct 2014 14:39:47 +0100 [thread overview]
Message-ID: <20141016133947.GB24714@leverpostej> (raw)
In-Reply-To: <543CFC41.2060506@atmel.com>
[...]
> >> That said, if we can build this dynamically, can't we always do so, and
> >> never need this property?
> >
> > Since board like at91sam9x5, sama5d3xek has a rom lookup table. And
> > the sama5d4ek has no rom lookup table.
> > To present this, I make this property as optional.
> >
> > But yes, the pmecc lookup table related properties can be removed as
> > driver can build it in runtime.
> > The cost is we need to use more memory to store the table.
>
> In precisely, the table need to 32k bytes memory for 512-sector, and 64k
> bytes for 1024-sector.
>
> Also I spend time to testing the performance of this version.
> Compare with the version which use the SRAM rom lookup table, this
> version (build table in runtim) cost about 5~10ms more.
>
> So I prefer to keep this property as optional.
Sure. It sounds like it's always possible to ignore it later if we
choose to.
I just wouldn't mention what the driver should do in the binding --
whether or not the property is optional, the behaviour of the driver is
not a detail of the device.
Thanks,
Mark.
next prev parent reply other threads:[~2014-10-16 13:40 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-11 10:01 [PATCH v3] mtd: atmel_nand: make PMECC lookup table and offset property optional Josh Wu
2014-10-13 11:16 ` Mark Rutland
2014-10-13 11:31 ` Josh Wu
2014-10-14 10:34 ` Josh Wu
2014-10-16 13:39 ` Mark Rutland [this message]
2014-10-29 6:41 ` Josh Wu
2014-11-05 22:44 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141016133947.GB24714@leverpostej \
--to=mark.rutland@arm.com \
--cc=Pawel.Moll@arm.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=josh.wu@atmel.com \
--cc=linux-mtd@lists.infradead.org \
--cc=nicolas.ferre@atmel.com \
--cc=robh+dt@kernel.org \
--cc=voice.shen@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox