From: Brian Norris <computersforpeace@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: Hauke Mehrtens <hauke@hauke-m.de>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
"Woodhouse, David" <David.Woodhouse@intel.com>,
Artem Bityutskiy <dedekind1@gmail.com>
Subject: Re: [PATCH] mtd: bcm47xxpart: only register partitions if the trx header was filled
Date: Wed, 22 Oct 2014 02:05:17 -0700 [thread overview]
Message-ID: <20141022090517.GQ16128@brian-ubuntu> (raw)
In-Reply-To: <CACna6rw+DmGzKhg-YKot8n+w-cYt9XoPzcUc5eK42WnDbPU39g@mail.gmail.com>
On Tue, Sep 23, 2014 at 02:27:59PM +0200, Rafał Miłecki wrote:
> On 22 September 2014 00:33, Hauke Mehrtens <hauke@hauke-m.de> wrote:
> > diff --git a/drivers/mtd/bcm47xxpart.c b/drivers/mtd/bcm47xxpart.c
> > index 8057f52..c3f4454 100644
> > --- a/drivers/mtd/bcm47xxpart.c
> > +++ b/drivers/mtd/bcm47xxpart.c
> > @@ -168,18 +168,22 @@ static int bcm47xxpart_parse(struct mtd_info *master,
> > i++;
> > }
> >
> > - bcm47xxpart_add_part(&parts[curr_part++], "linux",
> > - offset + trx->offset[i], 0);
> > - i++;
> > + if (trx->offset[i]) {
> > + bcm47xxpart_add_part(&parts[curr_part++], "linux",
> > + offset + trx->offset[i], 0);
>
> You may at least move "linux" to the next line to don't exceed 80
> chars limit. Same for "rootfs" below.
Rewrapped and pushed to l2-mtd.git.
Brian
prev parent reply other threads:[~2014-10-22 9:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-21 22:33 [PATCH] mtd: bcm47xxpart: only register partitions if the trx header was filled Hauke Mehrtens
2014-09-22 18:28 ` Brian Norris
2014-09-23 12:27 ` Rafał Miłecki
2014-10-22 9:05 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022090517.GQ16128@brian-ubuntu \
--to=computersforpeace@gmail.com \
--cc=David.Woodhouse@intel.com \
--cc=dedekind1@gmail.com \
--cc=hauke@hauke-m.de \
--cc=linux-mtd@lists.infradead.org \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox