From: Brian Norris <computersforpeace@gmail.com>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: "linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH] mtd: docg3: fix 'defined but not used' warning
Date: Wed, 22 Oct 2014 14:02:03 -0700 [thread overview]
Message-ID: <20141022210203.GE1193@ld-irv-0074> (raw)
In-Reply-To: <87tx2vlwsg.fsf@free.fr>
On Wed, Oct 22, 2014 at 09:38:39PM +0200, Robert Jarzmik wrote:
> Brian Norris <computersforpeace@gmail.com> writes:
>
> > On Wed, Oct 22, 2014 at 10:23 AM, Brian Norris
> > <computersforpeace@gmail.com> wrote:
> >> drivers/mtd/devices/docg3.c:2122:28: warning: 'docg3_dt_ids' defined but not used [-Wunused-variable]
> >> static struct of_device_id docg3_dt_ids[] = {
> >
> > I suppose I should add that this only happens when CONFIG_OF=n. I'll
> > add this to the commit message if/when I apply this.
>
> Thanks Brian, I had forgotten the non device-tree case, and overviewed the
> warning. Your change is the way to go.
OK, applied to l2-mtd.git.
Brian
prev parent reply other threads:[~2014-10-22 21:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 17:23 [PATCH] mtd: docg3: fix 'defined but not used' warning Brian Norris
2014-10-22 17:33 ` Brian Norris
2014-10-22 19:38 ` Robert Jarzmik
2014-10-22 21:02 ` Brian Norris [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141022210203.GE1193@ld-irv-0074 \
--to=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox